Fix: Notification click listener fires on cold start

[jennantilla]

Description

One Line Summary

Ensure notification click listener fires on cold start

Details

The native notification click listener is currently added on initialization, rather than when the listener method is explicitly called. This could lead to timing issues where the listener is added after the onClick event. Moving the listener out of initialization and into the bridge method follows other wrapper implementations.

Motivation

It was reported that on certain implementations of Ionic and Cordova apps, the notification click listener was not firing on cold start. Making this change fixes that issue and allows the listener to fire when the notification is clicked from cold start, background, and foreground app states.

Testing

Manual testing

Tested opening a notification while the app was both backgrounded and from a cold start. App build with Android Studio 2023.2.1 with a fresh install of the OneSignal example app on a Pixel 6 with Android 14.

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
  • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
  • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
• I have reviewed this PR myself, ensuring it meets each checklist item
  • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

---

This change is 

[emawby]

Do we always want to add ourselves as a click listener when the customer adds one? We should probably only do it once.

[emawby]

Have you tested with hotreload? If you hotreload do we still only fire the callback once?

[jennantilla]

Good callout! I successfully tested adding the listener with hot reload: the callback only fires once.