Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pausing IAMs dismisses any currently showing IAM #1480

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Sep 11, 2024

Description

One Line Summary

Setting in app messages to paused while there is currently an IAM being displayed dismisses the IAM.

Details

This is a fairly simple change that just detects if there is currently an IAM being displayed when paused is set to true. If so we dismiss the IAM.

Motivation

Add the ability to programmatically close an IAM. This could be used in response to the IAM click listener, or some other event happening in the application

Scope

In App Messages

Testing

Manual testing

Tested that queued IAMs don't show and that lifecycle callback listeners fire.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Copy link
Contributor

@jennantilla jennantilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested pausing an IAM in Lifecycle Listener onDidDisplay and the IAM successfully dismisses.

Tested that queued IAMs don't show and that lifecycle callback listeners fire.
@emawby emawby force-pushed the feat/close_IAM_programatically branch from e5af13f to 296ec63 Compare September 12, 2024 17:18
@emawby emawby merged commit f8c8ee7 into main Sep 12, 2024
2 of 3 checks passed
@emawby emawby deleted the feat/close_IAM_programatically branch September 12, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants