Remove +[UIApplication load], Remove -[UIApplication setDelegate:] swizzle #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
order to prevent swizzling before the library is instantiated (IF it is instantiated at all) - Remove `-[UIApplication setDelegate:]` swizzle in favor of manually calling `+[OneSignal swizzleSelectors]` during init, which kicks off all required method swizzling. This method also wraps the sensitive code in a `dispatch_once` block in order to prevent multiple swizzles from happening if init is called more than once - Force swizzle before all tests execute to accomodate previous commit - Add some pretty prints to make debugging easier - Attempts to swizzle the current UNUserNotificationCenterDelegate during +[UNUserNotificationCenter swizzleSelectors] just in case the delegate has already been set by the time this method is called - Fixes potential memory leak in Reachability - Missing -[UIViewController viewDidLoad] super call - Update binary - Revert memory leak "fix"
|
@alexhillc Thanks for sharing the changes. Some of our wrapping SDKs for other frameworks such as Unity, Cordova, Xamarin, etc might be effected by this. Before merging this in it will need to be tested for these cases. We may need a flag to disabling sizzling with a flag instead depending if this effects them. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+[UIApplication load]in OneSignal class implementation in order to prevent swizzling before the library is instantiated (IF it is instantiated at all)-[UIApplication setDelegate:]swizzle in favor of manually calling+[OneSignal swizzleSelectors]during init, which kicks off all required method swizzling. This method also wraps the sensitive code in adispatch_onceblock in order to prevent multiple swizzles from happening if init is called more than onceThe use cases for making these changes:
-[UIApplication setDelegate:]. This allows the SDK to lie "dormant" while not in useNot sure if this will be appreciated, but I figured if I was going to make changes, I may as well PR them!
This change is