Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restsharp version bump and migrations to latest restsharp changes #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EtiSandeep
Copy link

Description

One Line Summary

REQUIRED - Updated the RestSharp and other nuget packages to latest version and migrated the restsharp code to latest changes.

Details

Motivation

REQUIRED - The version of restsharp is very old and is preventing the users to update the restsharp version for dependent projects.

Testing

Manual testing

REQUIRED - Tested createNotification api to send message to Subscribed Users segment.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant