Gallery App not finding any screenshots after Tweaks/Advanced/Reset Everything #1386
Closed
3 tasks done
Comments
|
Adding more info for when there's time for one of us to check: Reproduced after resetting everything, but only with using your screenshot folder you attached and only when it tries to load an odd sized image (not 640x480). - worked fine with my screenshots dir after resetting (all 640x480)
Seg faults when it gets to an image that's not 640x480: Then loads the infoPanel here: 
All Assembloids load fine, Battlezone 2000 does not. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 24, 2024
…d to be stretched (#1418) Closes #1386 The images that crashed the infoPanel were in a different format, which SDL_SoftStretch couldn't handle, leaving image_to_draw empty and subsequently crashing when drawing the empty image. To safeguard against this, create a separate surface and check the return of SoftStretch for error. Testing this showed that some of the stretched images looked horrible, so now only stretch images if they are too big to fit the screen. (MMv4 752x560 screenshots mainly) Additionally, add some error handling to the Gallery launch script, so it would show "Error" instead of "No screenshots found" when infoPanel crashes to be less misleading. To test, copy the screenshot folder from the issue #1386 to your SD/Screenshots and confirm it doesn't crash when loading the different screenshots. --------- Co-authored-by: XK <47260768+XK9274@users.noreply.github.com> Co-authored-by: Aemiii91 <44569252+Aemiii91@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Onions OS Version
4.3.0 Beta 8ae761f
Miyoo Firmware Version
202306282128
Provide a clear and concise description of the issue
After running reset everything Gallery app will not find any screenshots.
Steps to Reproduce
I stupidly created a New Configuration File in retro arch.
Then starting C64 games there was no sound. Game showed yellow notification on startup, (sorry didn't take note of message).
I did not know how to fix it.
I went to Tweak/Advanced/Reset Everything.
Then Gallery would not find any screenshots.
I uninstalled and reinstalled Gallery via Package manager
Now it shows two images Corrupted (1/257), (2/257) then when you tap right a third time it displays "No screenshots found"
Provide any additional context or information that may help us investigate your issue
I have tried uninstalling and reinstall Gallery and rebooting in between a few time but this has not helped.
I noticed the two images that are displayed as corrupted are the first two screenshots. I tried deleting the first two images but that did not help. It just shows the new first two images as corrupt.
I have attached three images of the UI so you can see what is happening.
I have also attached my full screenshot folder. I don't think there is any corruption.
Using File Explorer app screenshots appear correct as they do on my windows PC.
So it appears running Reset Everything has done something? I know Onion OS version 4.2.3 it was working. But had not tried it in Beta 4.3.0 until I ran reset everything.
Main UI Screenshots.zip
Screenshots Folder.zip
The text was updated successfully, but these errors were encountered: