Tweaks: Added option to mute BGM in MainUI

[theUnBurn]

This commit adds the ability to mute music, independently of the volume set. This is done so users can mute bgm while still having menuing sounds play.

The toggle will live in tweaks, in "Appearance --> Theme Overrides... --> Mute background music"

[XK9274]

Built & tested earlier. Works great and does what it says - thanks for the first contribution!

I have noticed when you change theme with mute active the mute status is reset and the json key is removed from system.json so the theme you had muted previously is no longer muted, the tweaks menu item is also reset to 0

/ # cat /appconfigs/system.json
{
        "vol":  15,
        "keymap":       "L2,L,R2,R,X,A,B,Y",
        "mute": 0,
        "bgmmute":      1,
        "bgmvol":       20,
        "brightness":   10,
        "language":     "en.lang",
        "hibernate":    15,
        "lumination":   6,
        "hue":  10,
        "saturation":   10,
        "contrast":     10,
        "theme":        "/mnt/SDCARD/Themes/Silky by DiMo/",
        "fontsize":     24,
        "audiofix":     1,
        "wifi": 1
}

becomes:

 # cat /appconfigs/system.json
{
        "vol":  15,
        "keymap":       "L2,L,R2,R,X,A,B,Y",
        "mute": 0,
        "bgmvol":       20,
        "brightness":   10,
        "language":     "en.lang",
        "hibernate":    15,
        "lumination":   6,
        "hue":  10,
        "saturation":   10,
        "contrast":     10,
        "theme":        "/mnt/SDCARD/Themes/Onion Boy DX by PixelShift/",
        "fontsize":     24,
        "audiofix":     1,
        "wifi": 1
}/ #

(and also the copy on the SDCARD):

/ # cat /mnt/SDCARD/system.json
{
        "vol":  15,
        "keymap":       "L2,L,R2,R,X,A,B,Y",
        "mute": 0,
        "bgmmute":      1,
        "bgmvol":       20,
        "brightness":   10,
        "language":     "en.lang",
        "hibernate":    15,
        "lumination":   6,
        "hue":  10,
        "saturation":   10,
        "contrast":     10,
        "theme":        "/mnt/SDCARD/Themes/Onion Boy DX by PixelShift/",
        "fontsize":     24,
        "audiofix":     1,
        "wifi": 1
}

/ # cat /mnt/SDCARD/system.json
{
        "vol":  15,
        "keymap":       "L2,L,R2,R,X,A,B,Y",
        "mute": 0,
        "bgmvol":       20,
        "brightness":   10,
        "language":     "en.lang",
        "hibernate":    15,
        "lumination":   6,
        "hue":  10,
        "saturation":   10,
        "contrast":     10,
        "theme":        "/mnt/SDCARD/Themes/Silky by DiMo/",
        "fontsize":     24,
        "audiofix":     1,
        "wifi": 1
}

I'm happy to approve but is this something you wanted to address or are you happy with the way it is? It would be great if the mute was persistent.

The system.json file does get moved around a bit, runtime.sh may hold the answers to why this happens :)

[theUnBurn]

Hi @XK9274 ! Thanks for taking a look; I updated the *_system.jsons to have bgmmute; do notice that the bgms are now muted globally. Please let me know if this is what you were referring to!

[XK9274]

Hi @XK9274 ! Thanks for taking a look; I updated the *_system.jsons to have bgmmute; do notice that the bgms are now muted globally. Please let me know if this is what you were referring to!

Hi! No worries, apologies for that - i spoke with Schmurtz and he's happy with it not being persistent and the reasoning was that it potentially undermines the theme authors work if we turn it off permanently which does make sense, it should be a choice at discovery of the theme which is fine by me.

If you agree, you can revert your last commit of 2d1bb9b and @ me and i'll approve as i've already tested.

[theUnBurn]

This makes sense to me too! Thanks @XK9274 , I have reverted the last commit and should be ready to go!

[XK9274]

Tested & approving, does what it says with the caveat that when themes are changed the mute is reverted, but this has been discussed (see above for context) - we can revisit in the future based on feedback from the community if it comes up. Thanks again for the contribution @theUnBurn!