BLF Menu lockup in certain circumstances #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove "None" - it's redundant and causes issues - Fix menu lockup when scrolling, check if BLF is actually on before setting "blf_changing = true;" to negate needlessly locking the menu items. The artificial lockup on menu items is only needed when BLF is actually changing to avoid race conditions and pulling the display settings out of sync (causes flickering/bad previous state of RGB values, etc)
XK9274
referenced
this pull request
Dec 21, 2023
- toggle is now a toggle menu icon - menu item for toggle and intensity are disabled while script is working to keep the sync (lock file in tmp) - intensity now changes in realtime & smooth fade - add hotkey of Menu + B for 2 seconds to enable BLF - some UI/fading improvements - tidy up - persistent across boots if manually enabled in tweaks via "Toggle now" - Ignore the schedule for the current session if a manual toggle is done with the hotkey (saves going into tweaks when it's bouncing) The logic behind this is: - If the user disables the BLF for some reason while schedule is enabled we'll skip the schedule for this session, the user can remove this flag (/tmp/.blfIgnoreSchedule) by flipping the schedule on/off. - I chose this method of wiping the schedule flag so if the user takes no action, when they restart the schedule is still on for the next session. --------- Co-authored-by: XK9274 <XK9274@users.noreply.github.com> Co-authored-by: Schmurtz <schmurtz@gmail.com>
schmurtzm
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Great improvement ! I'm not able to triggers any failure in my test.
Yes there is a delay when we set the strength level, so yes the spinner could be a beautiful refinement (not an absolute mandatory because once setted you don't modify it every day imo).
As alternative, instead creating a complex SDL spinner you could just change dynamically the "Stength" label like this :
Stength -> Stength. -> Stength.. -> Stength... -> Stength -> Stength. -> Stength.. ,etc..
XK9274
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you get segfaults with this PR, run this in terminal before (The max value is no longer 5):
rm -rf /mnt/SDCARD/.tmp_update/config/display/blueLightLevelFixes: ddc9a9a#commitcomment-135316788
This is only a fix for when in the tweaks menu. The artificial delay is required. Setting display values into the screen gives no easy way to read them besides saving to file (this feature runs inside and outside tweaks so it's a settings value that's bitshifted).
Ideally this feature should run on a command queue/buffer and be processed as they come in so we don't have to try and keep sync...
It would also be great to get a "spinner" as discussed in discord, for when we don't need a full dialog, but need to show the user that something is happening in the background.. Something to look at in tweaks for the future i think.