Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed default consultingType overrides #1024

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: removed default consultingType overrides #1024

merged 1 commit into from
Mar 13, 2024

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Mar 13, 2024

Fixes #

Proposed Changes

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Mar 13, 2024

PR Summary

  • Removal of consultingType object contents
    The contents of the consultingType object, which are located within the consultingTypes.json file, have been completely removed. As a result, the consultingType object is now empty. The impact of this change should be evaluated against where and how this object is used in the system.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

janrembold
janrembold approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@janrembold janrembold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So mag ich das!!! +2 -904 loc 🥇

@web-mi web-mi merged commit 5b52f37 into develop Mar 13, 2024
8 checks passed
@web-mi web-mi deleted the fix/OB-10875 branch March 13, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janrembold janrembold janrembold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web-mi @janrembold