Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added error handling from OC #204

Merged
merged 2 commits into from
Oct 27, 2021
Merged

feat: added error handling from OC #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01cdc1c
feat: added error handling from OC
isaackps Oct 27, 2021
cf70c74
fix: lint in test file
isaackps Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
370 changes: 368 additions & 2 deletions src/validator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
import { isValid } from "./validator";
import { VerificationFragment } from "./types/core";
import {
isValid,
isDocumentStoreAddressOrTokenRegistryAddressInvalid,
contractNotFound,
certificateNotIssued,
certificateRevoked,
invalidArgument,
serverError,
unhandledError,
} from "./validator";
import { VerificationFragment, InvalidVerificationFragment } from "./types/core";

describe("isValid", () => {
it("should throw an error when no fragments are provided", () => {
Expand Down Expand Up @@ -249,3 +258,360 @@ describe("isValid", () => {
});
});
});

describe("isDocumentStoreAddressOrTokenRegistryAddressInvalid", () => {
it("should return true if document store address is invalid", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 1,
codeString: "1",
message: "Invalid document store address",
},
};
expect(isDocumentStoreAddressOrTokenRegistryAddressInvalid([verificationFragment])).toStrictEqual(true);
});
it("should return false if document store address is valid", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 2,
codeString: "2",
message: "some other error",
},
};
expect(isDocumentStoreAddressOrTokenRegistryAddressInvalid([verificationFragment])).toStrictEqual(false);
});
it("should return true if token registry address is invalid", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 1,
codeString: "1",
message: "Invalid token registry address",
},
};
expect(isDocumentStoreAddressOrTokenRegistryAddressInvalid([verificationFragment])).toStrictEqual(true);
});
it("should return false if token registry address is valid", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 2,
codeString: "2",
message: "some other error",
},
};
expect(isDocumentStoreAddressOrTokenRegistryAddressInvalid([verificationFragment])).toStrictEqual(false);
});
});

describe("contractNotFound", () => {
it("should return true if contract is not found in document store", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 1,
codeString: "1",
message: "Contract is not found",
},
};
expect(contractNotFound([verificationFragment])).toStrictEqual(true);
});
it("should return false if contract is found in document store", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 2,
codeString: "2",
message: "some other error",
},
};
expect(contractNotFound([verificationFragment])).toStrictEqual(false);
});
});

describe("certificateNotIssued", () => {
it("should return true if document not issued in document store", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 1,
codeString: "1",
message: "Contract is not found",
},
};
expect(certificateNotIssued([verificationFragment])).toStrictEqual(true);
});
it("should return false if document is issued in document store", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 2,
codeString: "2",
message: "Some Error",
},
};
expect(certificateNotIssued([verificationFragment])).toStrictEqual(false);
});
it("should return true if document not minted in token registry", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 1,
codeString: "1",
message: "Invalid token registry address",
},
};
expect(isDocumentStoreAddressOrTokenRegistryAddressInvalid([verificationFragment])).toStrictEqual(true);
});
it("should return false if document is minted in token registry", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 2,
codeString: "2",
message: "Some error",
},
};
expect(isDocumentStoreAddressOrTokenRegistryAddressInvalid([verificationFragment])).toStrictEqual(false);
});
});

describe("certificateRevoked", () => {
it("should return true if error reason is that document is revoked in document store", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 5,
codeString: "5",
message: "Document has been revoked",
},
};
expect(certificateRevoked([verificationFragment])).toStrictEqual(true);
});
it("should return false if error reason is that document is not revoked in document store", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 3,
codeString: "3",
message: "Some error, Document not revoked",
},
};
expect(certificateRevoked([verificationFragment])).toStrictEqual(false);
});
});

describe("invalidArgument", () => {
it("should return true if error is caused by an invalid merkle root in document store issued fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 1,
codeString: "1",
message: "Invalid call arguments",
},
};
expect(invalidArgument([verificationFragment])).toStrictEqual(true);
});
it("should return false if error is caused by an invalid merkle root in document store issued fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 3,
codeString: "3",
message: "Some other error",
},
};
expect(invalidArgument([verificationFragment])).toStrictEqual(false);
});
it("should return true if error is not caused by an invalid merkle root in token registry issued fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 6,
codeString: "6",
message: "Invalid contract arguments",
},
};
expect(invalidArgument([verificationFragment])).toStrictEqual(true);
});
it("should return false if error is not caused by an invalid merkle root in token registry issued fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 2,
codeString: "2",
message: "Some other error",
},
};
expect(invalidArgument([verificationFragment])).toStrictEqual(false);
});
});

describe("serverError", () => {
it("should return true of the reason of the error is that we can't connect to Ethereum for document store issued fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 500,
codeString: "500",
message: "Server error",
},
};
expect(serverError([verificationFragment])).toStrictEqual(true);
});
it("should return true of the reason of the error is that we can't connect to Ethereum for token registry minted fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 500,
codeString: "500",
message: "Server error",
},
};
expect(serverError([verificationFragment])).toStrictEqual(true);
});
it("should return false of the reason of the error is not that we can't connect to Ethereum for document store issued fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 3,
codeString: "3",
message: "Some other error",
},
};
expect(serverError([verificationFragment])).toStrictEqual(false);
});
it("should return false of the reason of the error is not that we can't connect to Ethereum for token registry minted fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 5,
codeString: "5",
message: "Some other error",
},
};
expect(serverError([verificationFragment])).toStrictEqual(false);
});
});

describe("unhandledError", () => {
it("should return true if there are some unhandled errors from document store issued fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 3,
codeString: "3",
message: "Some unhandled error",
},
};
expect(unhandledError([verificationFragment])).toStrictEqual(true);
});
it("should return false if not some unhandled errors from document store issued fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumDocumentStoreStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 1,
codeString: "1",
message: "Some other error",
},
};
expect(unhandledError([verificationFragment])).toStrictEqual(false);
});
it("should return true if there are some unhandled errors from token registry minted fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 3,
codeString: "3",
message: "Some unhandled error",
},
};
expect(unhandledError([verificationFragment])).toStrictEqual(true);
});
it("should return false if not some unhandled errors from token registry minted fragment", () => {
const verificationFragment: InvalidVerificationFragment<any> = {
status: "INVALID",
name: "OpenAttestationEthereumTokenRegistryStatus",
type: "DOCUMENT_STATUS",
data: {},
reason: {
code: 5,
codeString: "5",
message: "Some other error",
},
};
expect(unhandledError([verificationFragment])).toStrictEqual(false);
});
});
Loading