Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call optionally cbuild2cmake instead of cbuildgen #167

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Feb 12, 2024

Addressing #165

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Test Results

  4 files  ±  0   40 suites  +4   5s ⏱️ +2s
184 tests + 25  184 ✅ + 25  0 💤 ±0  0 ❌ ±0 
736 runs  +100  736 ✅ +100  0 💤 ±0  0 ❌ ±0 

Results for commit 509e865. ± Comparison against base commit d2aa039.

♻️ This comment has been updated with latest results.

pkg/builder/cbuildidx/builder.go Show resolved Hide resolved
pkg/builder/csolution/builder.go Outdated Show resolved Hide resolved
pkg/builder/csolution/builder.go Outdated Show resolved Hide resolved
pkg/builder/cbuildidx/builder.go Outdated Show resolved Hide resolved
pkg/builder/cbuildidx/builder.go Outdated Show resolved Hide resolved
@soumeh01 soumeh01 force-pushed the cbuild2cmake branch 6 times, most recently from 795fc3a to 93b9338 Compare February 14, 2024 12:34
pkg/builder/cbuildidx/builder_test.go Outdated Show resolved Hide resolved
pkg/builder/cbuildidx/builder_test.go Outdated Show resolved Hide resolved
pkg/builder/cbuildidx/builder_test.go Outdated Show resolved Hide resolved
pkg/builder/cbuildidx/builder_test.go Outdated Show resolved Hide resolved
pkg/builder/csolution/builder.go Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Feb 15, 2024

Code Climate has analyzed commit 509e865 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 86.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.9% (-0.5% change).

View more on Code Climate.

Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumeh01 soumeh01 merged commit 5d23fac into main Feb 19, 2024
15 of 16 checks passed
@soumeh01 soumeh01 deleted the cbuild2cmake branch February 19, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants