[cbuild] Reduce default verbosity when using cbuild2cmake mode
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
Code Climate has analyzed commit ac1cea2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 66.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 79.7% (0.0% change). View more on Code Climate. |
soumeh01
approved these changes
Jun 17, 2024
soumeh01
reviewed
Jun 17, 2024
| @@ -212,6 +212,10 @@ func (b CbuildIdxBuilder) Build() error { | |||
| args = append(args, "--target", b.BuildContext+"-database") | |||
| } | |||
|
|
|||
| if b.Options.Generator == "Ninja" && !(b.Options.Debug || b.Options.Verbose) { | |||
| args = append(args, "--", "--quiet") | |||
There was a problem hiding this comment.
@brondani Does this change mean
args = append(args, "--quiet")
There was a problem hiding this comment.
No, it means -- --quiet is added to args.
So --quiet is passed to the underlying build system, in this case Ninja, for example:
cmake --build <directory> --target <target> -- --quiet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned with Open-CMSIS-Pack/cbuild2cmake#135 improvements