Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbuild] Fix setup list layers arguments #278

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

brondani
Copy link
Collaborator

@brondani brondani commented Jul 19, 2024

During cbuild setup handling, the background csolution convert creates the cbuild-set.yml file since the --context-set option is mandatory. For this reason csolution list layers can simply use --context-set option.

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Test Results

  4 files  ±0   48 suites  ±0   7s ⏱️ +3s
225 tests +1  225 ✅ +1  0 💤 ±0  0 ❌ ±0 
900 runs  +4  900 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 33b6a0b. ± Comparison against base commit a291f0e.

♻️ This comment has been updated with latest results.

@brondani brondani marked this pull request as ready for review July 19, 2024 09:19
@brondani brondani requested a review from jkrech July 19, 2024 09:19
@brondani brondani force-pushed the cbuild-fix-setup-list-layers branch from 79f4479 to 33b6a0b Compare July 19, 2024 09:39
Copy link

codeclimate bot commented Jul 19, 2024

Code Climate has analyzed commit 33b6a0b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.7% (0.6% change).

View more on Code Climate.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit da0107c into main Jul 19, 2024
16 checks passed
@brondani brondani deleted the cbuild-fix-setup-list-layers branch July 19, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants