Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cbuild2cmake option and keeping it default option #296

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Sep 6, 2024

Addressing partially : Open-CMSIS-Pack/devtools#1700

As part of this PR:

  • Removed the --cbuild2cmake option.
  • Introduced the --cbuildgen option.

Note: The native CMake-based build approach will now be the default, without requiring an explicit option.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Test Results

  4 files  ±0   48 suites  ±0   6s ⏱️ ±0s
225 tests ±0  225 ✅ ±0  0 💤 ±0  0 ❌ ±0 
900 runs  ±0  900 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b58a89a. ± Comparison against base commit 6b53d04.

♻️ This comment has been updated with latest results.

Copy link

codeclimate bot commented Sep 9, 2024

Code Climate has analyzed commit b58a89a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.7% (0.0% change).

View more on Code Climate.

@soumeh01 soumeh01 marked this pull request as ready for review September 9, 2024 13:28
@soumeh01 soumeh01 requested a review from jkrech September 9, 2024 13:41
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 56da956 into main Sep 9, 2024
16 checks passed
@jkrech jkrech deleted the cmdlineOption branch September 9, 2024 14:02
Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants