Remove error when evaluating cpackget location #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrech
approved these changes
Apr 24, 2022
There was a problem hiding this comment.
In any case the role of of cbuild is the orchestration of a defines set of tools. Some of them are optional (e.g. xmllint), others are mandatory (e.g. cbuildgen, CMake, ninja). cpackget is somewhere in the middle depending on the use case. E.g. if csolution was already executed the required packs must be present already. Therefore it seems sensible to only throw an error about missing cpackget at the point when it actually would be invoked listing the missing packs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove error when evaluating cpackget location since its presence is not mandatory.
Issue #2