Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbuild] Rework csolution list layers arguments in cbuild setup background call #301

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

brondani
Copy link
Collaborator

Address Open-CMSIS-Pack/devtools#1760

In the background csolution list layers call, remove the fixed --load=all argument.
Take the arguments from the original cbuild setup call if specified.

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

Test Results

  4 files  ±0   48 suites  ±0   7s ⏱️ -1s
226 tests ±0  226 ✅ ±0  0 💤 ±0  0 ❌ ±0 
904 runs  ±0  904 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 10245c3. ± Comparison against base commit 40fe18b.

Copy link

codeclimate bot commented Sep 12, 2024

Code Climate has analyzed commit 10245c3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.5% (-0.2% change).

View more on Code Climate.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's experiment

@jkrech jkrech merged commit 330eba4 into main Sep 12, 2024
15 of 16 checks passed
@jkrech jkrech deleted the cbuild-rework-setup-list-layers branch September 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants