Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpackget] cpackcpackget deletes pack file content when installing from $CMSIS_PACK_ROOT/.Download/ #276

Closed
jkrech opened this issue Apr 2, 2024 · 1 comment
Closed

[cpackget] cpackcpackget deletes pack file content when installing from $CMSIS_PACK_ROOT/.Download/ #276

jkrech opened this issue Apr 2, 2024 · 1 comment
Assignees
@edriouk

Comments

@jkrech
Copy link
Member

jkrech commented Apr 2, 2024 •
edited
Loading

Describe the bug

When a user installs an already downloaded pack version file from $CMSIS_PACK_ROOT/.Download/<pack-vendor>.<pack-name>.<version>.pack this file will have the size 0 after the installation process is complete.

To Reproduce
Steps to reproduce the behavior:

  1. Download any pack version file from your $CMSIS_PACK_ROOT/.Download/ directory using cpackget add specifying the path and pack filename.
  2. Inspect the file size after the installation is completed. It is no longer a valid zip archive and the file size is 0.

Expected behavior
It is expected that the pack version file will get installed and the pack file version in the .Download directory remains unchanged. The problem is that the source and destination are identical when storing the pack file.

Environment (please complete the following information):

  • OS: any
  • Version: 2.1.0
@jkrech jkrech added the bug Something isn't working label Apr 2, 2024
@jkrech jkrech removed the bug Something isn't working label Apr 2, 2024
@jkrech
Copy link
Member Author

jkrech commented Apr 2, 2024

False alarm. Works as Expected Behavior already.

@jkrech jkrech changed the title [cpackget] fails to add pack version from file when it is a public pack and version is not part of the release history [cpackget] cpackcpackget deletes pack file content when installing from $CMSIS_PACK_ROOT/.Download/ Apr 2, 2024
edriouk added a commit that referenced this issue Apr 2, 2024
@edriouk
[cpackget] cpackcpackget deletes pack file content when installing fr…
b75890c 
…om $CMSIS_PACK_ROOT/.Download/ #276
@edriouk edriouk mentioned this issue Apr 2, 2024
Merged
edriouk added a commit that referenced this issue Apr 4, 2024
@edriouk
[cpackget] cpackcpackget deletes pack file content when installing fr…
5bc211a 
…om $CMSIS_PACK_ROOT/.Download/ #276
edriouk added a commit that referenced this issue Apr 4, 2024
@edriouk
Keep downloaded pack #276 (#277)
2a4e9e1 
[cpackget] cpackcpackget deletes pack file content when installing from
$CMSIS_PACK_ROOT/.Download/ #276
@edriouk edriouk closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edriouk edriouk

Labels
None yet
Projects
No open projects
CMSIS-Toolbox 2.3.0
Status: Done
CMSIS-Toolbox 2.4.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jkrech @edriouk @thorstendb-ARM