[packchk] Rework Message M396 #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
grasci-arm
commented
Jan 26, 2023
grasci-arm
commented
- M396 to ERROR
- no check for ascending date anymore
- added case to test data
- M396 to ERROR - no check for ascending date anymore - added case to test data
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 50.87% 50.86% -0.01%
==========================================
Files 116 116
Lines 21270 21266 -4
Branches 11665 11661 -4
==========================================
- Hits 10821 10818 -3
Misses 8452 8452
+ Partials 1997 1996 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JonatanAntoni
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.