Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device generator #24

Merged
merged 10 commits into from
Feb 1, 2024
Merged

Device generator #24

merged 10 commits into from
Feb 1, 2024

Conversation

bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Jan 15, 2024

Fixed indeterministic shuffle of contexts in MX_Device.h and added path of MX_Device.h to add-path: in *cgen.yml.

Copy link

github-actions bot commented Jan 15, 2024

Test Results

  6 files  ±  0   54 suites  +6   4s ⏱️ -1s
 71 tests + 30   71 ✅ + 30  0 💤 ±0  0 ❌ ±0 
426 runs  +180  426 ✅ +180  0 💤 ±0  0 ❌ ±0 

Results for commit f088567. ± Comparison against base commit 909acd8.

This pull request removes 3 and adds 33 tests. Note that renamed tests count towards both.
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getPeripherals1
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getPeripherals1/fail
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getPeripherals1/test
github.com/open-cmsis-pack/generator-bridge/internal/generator ‑ TestRead
github.com/open-cmsis-pack/generator-bridge/internal/generator ‑ TestRead/global-nix.yml
github.com/open-cmsis-pack/generator-bridge/internal/generator ‑ TestRead/global.yml
github.com/open-cmsis-pack/generator-bridge/internal/generator ‑ TestRead/wrong.yml
github.com/open-cmsis-pack/generator-bridge/internal/generator ‑ TestRead/wrong.yml#01
github.com/open-cmsis-pack/generator-bridge/internal/generator ‑ TestRead/xxx.yml
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getPeripherals/fail4
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getPeripherals/test1
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getPinConfiguration
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getPinConfiguration/test.msp
…

♻️ This comment has been updated with latest results.

thorstendb-ARM
thorstendb-ARM previously approved these changes Jan 15, 2024
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, but huge function, hard to read & understand.
Also unsure about the hard codes Cortex-M strings, in mxproject converter I used a more generic approach using the yaml tag "core"

added tests
added download info from global.generator.yml
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
In general, not sure if we should have strings for Peripherals to search for rather than just gathering them, but currently no idea how to fetch them from the headerfile :-)

@bgn42 bgn42 merged commit 72d4987 into main Feb 1, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants