-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filter_bbox #118
add filter_bbox #118
Conversation
This reverts commit bfd7a7e.
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 77.84% 76.65% -1.19%
==========================================
Files 25 25
Lines 1020 1071 +51
==========================================
+ Hits 794 821 +27
- Misses 226 250 +24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change, couple of comments!
@LukeWeidenwalker I updated the code using the .openeo accessor. However I noticed that calling data.openeo.spatial_dims throws an exception if the data has a single spatial dimension (you can get to this state using reduce_dimension(dimension='x',reducer='mean') for example). So, I updated the accessor to handle this scenario. Additionally, there's also another edge case I'm not sure how to solve, when there's a single value on x_dim or y_dim: we need to check if this coordinate is actually inside the bbox or not. If not, should we raise an exception? |
@clausmichele I just merged #125, please let me know if this doesn't resolve the issue that was blocking this PR! |
@LukeWeidenwalker now it should be fine and ready to be merged, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, this lgtm now!
Adding the
filter_bbox
process