-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[localprocessing] processing.py updates #411
Merged
soxofaan
merged 10 commits into
Open-EO:master
from
clausmichele:local_processing_updates
Apr 17, 2023
+43
−16
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3760747
fix for newer packages
clausmichele cfdcf41
improved band names handling
clausmichele f6abfef
Merge branch 'Open-EO:master' into local_processing_updates
clausmichele aa3a601
Merge branch 'Open-EO:master' into local_processing_updates
clausmichele 6ff39bb
Dependencies bump
clausmichele afc9e45
Merge branch 'local_processing_updates' of https://github.com/clausmi…
clausmichele 51009b1
Code improvement
clausmichele 47e0afa
Renamed requirements file and improved
clausmichele b35f758
wrap process_registry init in function
clausmichele 89d91fe
Improved code from suggestion
clausmichele File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Those requirements are for the experimental and optional client side processing feature | ||
# that can be installed via pip install openeo[localprocessing]. | ||
# Please be aware that this functionality is not fully stable and may change quickly. | ||
openeo-pg-parser-networkx==2023.3.1 | ||
openeo-processes-dask==2023.3.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm missing something, I think this can be done more compactly with:
Also, wouldn't it be better that openeo_processes_dask provide helpers to list implementations/spec, instead of having to use ugly
inspect.getmembers
andgetattr
constructs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukeWeidenwalker sorry if I tag you again, but I wasn't involved in this development of openeo-processes-dask so I couldn't tell the reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah apologies, I missed this tag - yes, agree with Stefaan, this is something openeo-processes-dask could do better - have created an issue to do this at some point!
Open-EO/openeo-processes-dask#92