Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port xtensa arch #175

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Port xtensa arch #175

merged 1 commit into from
Oct 29, 2021

Conversation

xiaoxiang781216
Copy link
Collaborator

-libmetal: add xtensa support
-libmetal: add __sync_synchronize support

@xiaoxiang781216 xiaoxiang781216 force-pushed the dev2 branch 3 times, most recently from 4b2a0b8 to 8b90f06 Compare October 14, 2021 17:28
arnopo
arnopo requested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @xiaoxiang781216

Minor comment and compliance check complain to fix
Then LGTM,

lib/processor/xtensa/atomic.h Outdated Show resolved Hide resolved
lib/processor/xtensa/CMakeLists.txt Outdated Show resolved Hide resolved
lib/processor/xtensa/cpu.h Show resolved Hide resolved
@arnopo arnopo added this to the Release V2022.04 milestone Oct 20, 2021
@arnopo arnopo requested a review from edmooring October 20, 2021 09:26
edmooring
edmooring requested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Arnaud's feedback. Otherwise, it looks good to me.

@xiaoxiang781216 xiaoxiang781216 force-pushed the dev2 branch 2 times, most recently from 82a50ee to 70249cf Compare October 22, 2021 03:53
arnopo
arnopo requested changes Oct 22, 2021
View reviewed changes
lib/processor/xtensa/atomic.h Outdated Show resolved Hide resolved
lib/processor/xtensa/cpu.h Outdated Show resolved Hide resolved
@GUIDINGLI @xiaoxiang781216
libmetal: add xtensa support
965e0e4 
make openamp can run on xtensa dsp

Signed-off-by: Guiding Li <liguiding1@xiaomi.com>
@arnopo arnopo requested a review from edmooring October 22, 2021 14:32
edmooring
edmooring approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@edmooring edmooring merged commit 000568d into OpenAMP:master Oct 29, 2021
@lenghonglin
Copy link

Hello, @xiaoxiang781216 This pr will not build passed for me with zephyr , the error message is missing sys. c and sys.h . and i create new dir in this path system/zephyr/xtensa and port sys.c and sys.h , the problem is be sloved.

image

@xiaoxiang781216 xiaoxiang781216 deleted the dev2 branch November 3, 2021 02:32
@xiaoxiang781216
Copy link
Collaborator Author

Hello, @xiaoxiang781216 This pr will not build passed for me with zephyr , the error message is missing sys. c and sys.h . and i create new dir in this path system/zephyr/xtensa and port sys.c and sys.h , the problem is be sloved.

image

I use NuttX porting, not Zephyr porting. it look like that sys.[h|c] is a Zephyr specific requirement. Could you create a PR fix this issue?

@dbaluta
Copy link
Contributor

dbaluta commented Jan 8, 2022 •
edited
Loading

@xiaoxiang781216 @lenghonglin I also met this issue. Will try to send a PR to fix it!

Update: See https://github.com/OpenAMP/libmetal/pulls

@lenghonglin
Copy link

Awwsome~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnopo arnopo arnopo approved these changes

@edmooring edmooring edmooring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release V2022.04
Development

Successfully merging this pull request may close these issues.
6 participants
@xiaoxiang781216 @lenghonglin @dbaluta @edmooring @arnopo @GUIDINGLI