Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic.h: fix conflicting type qualifiers compiler error #314

Closed
wants to merge 1 commit into from

Conversation

wyr-7
Copy link
Contributor

@wyr-7 wyr-7 commented Oct 10, 2024

fix compiler error:
nuttx/include/metal/compiler/gcc/atomic.h:19:13: error: conflicting type qualifiers for 'atomic_flag'
19 | typedef int atomic_flag;
| ^~~~~~~~~~~
In file included from nuttx/include/nuttx/net/netdev_lowerhalf.h:38,
from virtio/virtio-net.c:33:
prebuilts/gcc/linux/arm/lib/gcc/arm-none-eabi/13.2.1/include/
stdatomic.h:233:3: note: previous declaration of 'atomic_flag' with
type 'atomic_flag'
233 | } atomic_flag;
| ^~~~~~~~~~~
nuttx/include/metal/compiler/gcc/atomic.h:20:14: error: conflicting
type qualifiers for 'atomic_char'
20 | typedef char atomic_char;
^~~~~~~~~~~

@wyr-7 wyr-7 force-pushed the atomic_compile_err branch from 6a4146f to 2045777 Compare October 10, 2024 03:24
fix compiler error:
nuttx/include/metal/compiler/gcc/atomic.h:19:13: error: conflicting
type qualifiers for 'atomic_flag'
   19 | typedef int atomic_flag;
      |             ^~~~~~~~~~~
In file included from nuttx/include/nuttx/net/netdev_lowerhalf.h:38,
                 from virtio/virtio-net.c:33:
prebuilts/gcc/linux/arm/lib/gcc/arm-none-eabi/13.2.1/include/
stdatomic.h:233:3: note: previous declaration of 'atomic_flag' with
type 'atomic_flag'
  233 | } atomic_flag;
      |   ^~~~~~~~~~~
nuttx/include/metal/compiler/gcc/atomic.h:20:14: error: conflicting
type qualifiers for 'atomic_char'
   20 | typedef char atomic_char;
                     ^~~~~~~~~~~
Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com>
@wyr-7 wyr-7 force-pushed the atomic_compile_err branch from 2045777 to 440f4b6 Compare October 10, 2024 03:27
@arnopo arnopo requested review from edmooring, arnopo and tnmysh October 16, 2024 14:59
@arnopo arnopo mentioned this pull request Oct 16, 2024
@arnopo
Copy link
Contributor

arnopo commented Oct 16, 2024

Similar to #312 can be closed and addressed in #312

@wyr-7
Copy link
Contributor Author

wyr-7 commented Oct 18, 2024

Similar to #312 can be closed and addressed in #312

Ok, thanks.

@wyr-7 wyr-7 closed this Oct 18, 2024
@arnopo arnopo modified the milestone: Release v2024.10 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants