-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Linux kconfig for openamp #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UIO is a controversial feature. We should not enable it in the openamp.cfg which is used by every kernel and every machine (when openamp is in DISTRO_FEATURES). Instead move it to remoteproc-*.cfg as that is only included by specific machines (and also only when enabled via openamp DISTRO_FEATURE). The old config was not doing any good anyway as the base level UIO was not enabled. We fix this here also. Signed-off-by: Bill Mills <bill.mills@linaro.org>
The name service is a default part of rpmsg and should be enabled by default. Signed-off-by: Bill Mills <bill.mills@linaro.org>
Actually say what this file is for. Signed-off-by: Bill Mills <bill.mills@linaro.org>
The CONFIG_ name was changed on its way upstream. Use the name that made it upstream. Signed-off-by: Bill Mills <bill.mills@linaro.org>
Adding configs in both places just adds confusion. Only add things not already in openamp.cfg Signed-off-by: Bill Mills <bill.mills@linaro.org>
Since we are getting rid of BSP level files, move this define to the file we are keeping as it is part of the remoteproc enablement for Qualcomm platforms. Signed-off-by: Bill Mills <bill.mills@linaro.org>
These were added when we were using qemu targets as stand-ins for generic* targets. Now that we have genericarm64 and we also have meta-openamp-bsp for testing, we don't need these. Any BSP level configs should be at the BSP layer not in meta-openamp. Signed-off-by: Bill Mills <bill.mills@linaro.org>
When using genericarm64 with linux-yocto we get warnings when this is set to =m so switch to =y Signed-off-by: Bill Mills <bill.mills@linaro.org>
Enable the rpmsg sample for all machines that opt into the remoteproc mix-in. Signed-off-by: Bill Mills <bill.mills@linaro.org>
I am happy to pull specific commits out of this PR and in to another PR if their is a good reason to delay them. This PR is not strictly required for the OpenAMP 2024.05 release as I can do workarounds in the test BSP layer. However I would like to include all of these commits unless there is a compelling reason not to. |
No concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux Kconfig fix-up and clean-up