examples: dual_qemu_ivshmem: Print shmem address and size #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prints the shared memory (shmem) address and size for ivshmem. This information is useful in certain test scenarios, particularly when the remote side needs to be aware of the shmem address on the other side (host side). Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
|
Printing the address is fine. My question is about the colors. Does Zephyr already use colors in its logging? |
|
I tried a number of dumb terminal emulators and color schemes and its seems fine. |
arnopo
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@uLipe @arnopo @tnmysh Hi. This is a trivial change that will help when testing the
dual_qemu_ivshmemexample with the remote side running on a cortex-m machine with the QEMU ivshmem-flat device (no PCI, WIP). Could you please review it?Thank you,
Cheers