-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building zephyr with upstream open-amp and libmetal #25
Conversation
I have updated the *-module branches with a new commit that removes the use of the symlink. Please note the commented lines to find the libmetal headers and libs in the open-amp-module branch above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with success, I also proposed an alternative to squash the libmetal-module and open-amp-module in one
Just adding to the conversation, I also tested with no effort, it worked very well. |
west.yml
Outdated
@@ -7,6 +7,8 @@ manifest: | |||
url-base: https://github.com/OpenAMP | |||
- name: zephyr | |||
url-base: https://github.com/zyphyrproject-rtos | |||
- name: wam | |||
url-base: https://github.com/wmamills |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update to rely on https://github.com/OpenAMP/openamp-zephyr-modules?
I know that there is a way to specify the revision as a PR reference, waiting merge of OpenAMP/openamp-zephyr-modules#1, but i can not remeber the exact syntax for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it. But seems better to address is a separate PR
- name: openamp-zephyr-modules
remote: openamp-zephyr-modules
repo-path: openamp-system-reference
revision: pull/1/head
Use Zephyr from upstream when we don't have patches as it looks better Update to the v3.5.0 release as kv260_r5 needs it and we should pre-test with it before Zephyr updates to our 2023.10.* release. Signed-off-by: Bill Mills <bill.mills@linaro.org>
This manifest allows us to use our repos for the open-amp and libmetal libraries. As our libraries do not have the zephyr dir, they are not seem as zephyr modules. To make this work easily with zephyr we also add a zephyr glue layer. This layer _is_ seen as a zephyr module and integrates both libraries. Several approaches were tried for this and this was the chosen method for the following reasons: Pros: * All needed files are provided by just doing the west update * We don't need to set any ENV vars each time like EXTRA_ZEPHYR_MODULES * It works with our samples and zephyr stock samples * The version of open-amp and libmetal are directly controlled in the manifest * It is low maintenance as the module boiler plate is unlikely to change much. Cons: * One extra repo Signed-off-by: Bill Mills <bill.mills@linaro.org> Co-authored-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
This is now clean and ready. This is no longer an RFC. |
@uLipe any comment? |
@wmamill, no, still LGTM. |
Prototype stage only.
TODO:
DONE: modify to work on Windows also
DONE: Get rid of wam remote stuff
WIP will be a different PR: Add CI github action workflow