Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first Zephyr example #3

Merged
merged 8 commits into from
Nov 15, 2022
Merged

Add first Zephyr example #3

merged 8 commits into from
Nov 15, 2022

Conversation

arnopo
Copy link
Collaborator

@arnopo arnopo commented Oct 18, 2022

Install environment for zephyr examples by:

  1. porting the samples/subsys/ipc/openamp_rsc_table sample
  2. updating it to be able to replay the https://github.com/OpenAMP/openamp-system-reference/wiki/Samples-and-demos on the stm32mp157F-dK2 board

Copy link

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being a Zephyr expert, this is a less than substantive review.

west.yml Outdated Show resolved Hide resolved
…sample

Create the rpmsg multiservices example by copying the zephyr
samples/subsys/ipc/openamp_rsc_table sample.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
…servicee

Correction of the naming of some variables, from "sc" to "cs",
when used for the rpmsg "sample client" service

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
This sample will be extend to demonstrate multi rpmsg channels in parallel
change the name of the project that is named "zephyr_openamp_rsc_table"
in Zephyr.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Copy link

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wmamills
Copy link
Collaborator

I will provide suggested changes later today.
There are two main ones in the west manifest.

  • use main as the revision to avoid bumps every day
  • (We can have a different manifest for release tags)
  • rename openamp-zephyr-staging to zephyr on clone to keep the west usage simple

@wmamills
Copy link
Collaborator

wmamills commented Oct 26, 2022

I double checked and the only thing I modified was the manifest. What I have looks like this at the end:

  projects:
    - name: openamp-zephyr-staging
      path: zephyr
      revision: main
      import: true

With these changes you can change the readme to eliminate the -z openamp-zephyr-staging from the west command line.

@arnopo arnopo closed this Oct 27, 2022
@arnopo arnopo reopened this Oct 27, 2022
@arnopo
Copy link
Collaborator Author

arnopo commented Oct 27, 2022

I will provide suggested changes later today. There are two main ones in the west manifest.

  • use main as the revision to avoid bumps every day

This means that we would have to set the main branch of the on top of the Zephyr revision we want to use, to be aligned with a release. Or do you propose that we use the main branch of the zephyr main repo?

  • (We can have a different manifest for release tags)
  • rename openamp-zephyr-staging to zephyr on clone to keep the west usage simple

Right that would simplify the use, I will test it

add out of tree Zephyr manifest to allow to get the example
Add readme to explain how to setup and build environment

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Add a second TTY channel that could be instantiate by the remote side
using the name service announcement.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Allow to bind a rpmsg_tty channel and unbind it

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Add the support of a rpmsg raw channel that responds to Linux
rpmsg_char driver.


Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
@arnopo arnopo merged commit eb2b4d0 into OpenAMP:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants