-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first Zephyr example #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not being a Zephyr expert, this is a less than substantive review.
…sample Create the rpmsg multiservices example by copying the zephyr samples/subsys/ipc/openamp_rsc_table sample. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
…servicee Correction of the naming of some variables, from "sc" to "cs", when used for the rpmsg "sample client" service Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
This sample will be extend to demonstrate multi rpmsg channels in parallel change the name of the project that is named "zephyr_openamp_rsc_table" in Zephyr. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I will provide suggested changes later today.
|
I double checked and the only thing I modified was the manifest. What I have looks like this at the end:
With these changes you can change the readme to eliminate the -z openamp-zephyr-staging from the west command line. |
This means that we would have to set the
Right that would simplify the use, I will test it |
add out of tree Zephyr manifest to allow to get the example
Add readme to explain how to setup and build environment Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Add a second TTY channel that could be instantiate by the remote side using the name service announcement. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Allow to bind a rpmsg_tty channel and unbind it Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Add the support of a rpmsg raw channel that responds to Linux rpmsg_char driver. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Install environment for zephyr examples by: