fix(#198): use "finish" event instead of "end" to avoid race condition

OpenAPITools · Dec 23, 2020 · a5f6dce · a5f6dce
1 parent e1fab63
commit a5f6dce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/apps/generator-cli/src/app/services/version-manager.service.spec.ts b/apps/generator-cli/src/app/services/version-manager.service.spec.ts
@@ -365,14 +365,15 @@ describe('VersionManagerService', () => {
 
         const data = {
           pipe: jest.fn(),
+        };
+
+        const file = {
           on: jest.fn().mockImplementation((listener, res) => {
-            if (listener === 'end') {
+            if (listener === 'finish') {
               return res();
             }
           })
-        };
-
-        const file = Symbol();
+        }
 
         beforeEach(async () => {
           data.pipe.mockReset();

diff --git a/apps/generator-cli/src/app/services/version-manager.service.ts b/apps/generator-cli/src/app/services/version-manager.service.ts
@@ -113,7 +113,7 @@ export class VersionManagerService {
             fs.ensureDirSync(this.storage);
             const file = fs.createWriteStream(filePath);
             res.data.pipe(file);
-            res.data.on('end', resolve);
+            file.on('finish', resolve);
           })
         )).toPromise();