Merge pull request #297 from hiddewie/overwrite-move

fix: add overwrite: true to overwrite on existing file
OpenAPITools · Mar 10, 2021 · bf618d1 · bf618d1
2 parents 68b5d10 + b36d24e
commit bf618d1
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/apps/generator-cli/src/app/services/version-manager.service.spec.ts b/apps/generator-cli/src/app/services/version-manager.service.spec.ts
@@ -450,7 +450,7 @@ describe('VersionManagerService', () => {
           });
 
           it('moves the file to the target location', () => {
-            expect(fs.moveSync).toHaveBeenNthCalledWith(1, '/tmp/generator-cli-abcDEF/4.2.0', `${fixture.storage}/4.2.0.jar`);
+            expect(fs.moveSync).toHaveBeenNthCalledWith(1, '/tmp/generator-cli-abcDEF/4.2.0', `${fixture.storage}/4.2.0.jar`, {overwrite: true});
           });
 
           it('receives the data piped', () => {

diff --git a/apps/generator-cli/src/app/services/version-manager.service.ts b/apps/generator-cli/src/app/services/version-manager.service.ts
@@ -116,7 +116,7 @@ export class VersionManagerService {
             const file = fs.createWriteStream(temporaryFilePath);
             res.data.pipe(file);
             file.on('finish', content => {
-              fs.moveSync(temporaryFilePath, filePath);
+              fs.moveSync(temporaryFilePath, filePath, {overwrite: true});
               resolve(content);
             });
           })

diff --git a/package.json b/package.json
@@ -132,7 +132,7 @@
     "ts-jest": "26.5.3",
     "ts-node": "9.1.1",
     "tslint": "6.1.3",
-    "type-fest": "0.21.2",
+    "type-fest": "0.21.3",
     "typescript": "4.2.3"
   }
 }
diff --git a/yarn.lock b/yarn.lock
@@ -10468,10 +10468,10 @@ type-detect@4.0.8:
   resolved "https://registry.yarnpkg.com/type-detect/-/type-detect-4.0.8.tgz#7646fb5f18871cfbb7749e69bd39a6388eb7450c"
   integrity sha512-0fr/mIH1dlO+x7TlcMy+bIDqKPsw/70tVyeHW787goQjhmqaZe10uwLujubK9q9Lg6Fiho1KUKDYz0Z7k7g5/g==
 
-type-fest@0.21.2:
-  version "0.21.2"
-  resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-0.21.2.tgz#43b9dc71d9dc5593ea71bf7b0e013ec10f838249"
-  integrity sha512-pvQl0WNazvfQ0rq2XDdhpWv49sohh2t+buFbglaJ9N9+Xj4BhFRpuo+uJxemeARteRxRloJ1m+8gBR6Z2Nfktg==
+type-fest@0.21.3:
+  version "0.21.3"
+  resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-0.21.3.tgz#d260a24b0198436e133fa26a524a6d65fa3b2e37"
+  integrity sha512-t0rzBq87m3fVcduHDUFhKmyyX+9eo6WQjZvf51Ea/M0Q7+T374Jp1aUiyUl0GKxp8M/OETVHSDvmkyPgvX+X2w==
 
 type-fest@^0.11.0:
   version "0.11.0"