Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 3.0.1 release #280

Merged
merged 7 commits into from
Jun 11, 2018
Merged

Prepare 3.0.1 release #280

merged 7 commits into from
Jun 11, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jun 11, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

PR for previous release:

#190

Description of the PR

  • added a bash script to update files with ease
  • updated files with new version 3.0.1

@wing328 wing328 added this to the 3.0.1 milestone Jun 11, 2018
Modify `artifactId` of `CI/pom.xml.shippable` to be `openapi-generator-shippable-pom`
@jmini
Copy link
Member

jmini commented Jun 11, 2018

@wing328: Version is not updated in CI/pom.xml.shippable is that on purpose?


With b326731 I have modified the Shippable pom to build the root pom and its modules. This is something that is not specific to this release and that can be kept with 3.0.2-SNAPSHOT

It should fix this error (Shippable build 678):

[ERROR] [FATAL] Non-resolvable parent POM for org.openapitools:openapi-generator-cli:[unknown-version]: Could not find artifact org.openapitools:openapi-generator-project:pom:3.0.1 in sonatype-snapshots (https://oss.sonatype.org/content/repositories/snapshots) and 'parent.relativePath' points at wrong local POM @ line 3, column 11

@jmini
Copy link
Member

jmini commented Jun 11, 2018

Because of such diffs:

--- a/samples/server/petstore/springboot/src/main/java/org/openapitools/api/FakeApi.java
+++ b/samples/server/petstore/springboot/src/main/java/org/openapitools/api/FakeApi.java
@@ -1,5 +1,5 @@
 /**
- * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech) (3.0.1-SNAPSHOT).
+ * NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech) (3.0.1).
  * https://openapi-generator.tech
  * Do not edit the class manually.
  */

And for VERSION files (see ):

diff --git a/samples/server/petstore/springboot-beanvalidation/.openapi-generator/VERSION b/samples/server/petstore/springboot-beanvalidation/.openapi-generator/VERSION
index ad121e834..13d683ccb 100644
--- a/samples/server/petstore/springboot-beanvalidation/.openapi-generator/VERSION
+++ b/samples/server/petstore/springboot-beanvalidation/.openapi-generator/VERSION
@@ -1 +1 @@
-3.0.1-SNAPSHOT
\ No newline at end of file
+3.0.1
\ No newline at end of file

I have commented out bin/ensure-up-to-date in 522d0dc

@wing328
Copy link
Member Author

wing328 commented Jun 11, 2018

This will close #259

The release management changes moved from maven-publish (newer plugin)
to maven (older plugin, only one that works currently with signing).
This updates docs in the samples/local-spec project with current
directions.

Also:

* Includes sonatype releases/snapshots on repo lookup
* Adds openApiGeneratorVersion property
@jimschubert jimschubert merged commit 0453e64 into master Jun 11, 2018
@jimschubert jimschubert deleted the release_script branch June 11, 2018 14:32
@jmini jmini mentioned this pull request Jun 11, 2018
@jmini
Copy link
Member

jmini commented Jun 11, 2018

When release is OK we can move forward with #285

@jimschubert
Copy link
Member

@jmini do you mean to link to #285? This PR is 280.

@jmini
Copy link
Member

jmini commented Jun 11, 2018

Edited, thank you.

jimschubert pushed a commit that referenced this pull request Jun 11, 2018
Set version `3.0.2-SNAPSHOT`.

Follow up from #280
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 12, 2018
* master: (26 commits)
  Prepare 3.0.1 release (OpenAPITools#280)
  [typescript-angular] strict type checking (OpenAPITools#218)
  [C++ server] Adjust the names (script, sample folder, generator) to lang option (OpenAPITools#250)
  Removed warnings for packages included in SDK for Net Core 2.0 (OpenAPITools#269)
  [cli] Completions command for suggestions (OpenAPITools#213)
  [Java][RestTemplate] Fix query parameter URL encoding (OpenAPITools#260)
  [cpp-qt5] Remove std::shared_ptr from Qt5 (OpenAPITools#267)
  Adds some links to the README (OpenAPITools#261)
  Update sec.gpg.enc to binary encoded secret
  Add gpg --check-trustdb, limit gpg to master
  Re-do encrypted gpg and reference in settings.xml
  Fix trailing semicolons in after_success Travis CI scripts
  Use ubuntu keyserver instead of mit (due to timeout)
  [gradle] Plugin release management (OpenAPITools#201)
  Updates small typo in qna.md (OpenAPITools#262)
  Fix ModelUtils.getUnusedSchema() (OpenAPITools#253)
  Add JaxRS to bin/ensure-up-to-date (OpenAPITools#248)
  feat(security): add cookie-auth support (OpenAPITools#240)
  Add 'unblu inc.' to company list (OpenAPITools#246)
  put company list in alphabetical order (OpenAPITools#244)
  ...
This was referenced Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants