Prepare 3.1.2-SNAPSHOT #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wing328
reviewed
Jul 18, 2018
README.md
Outdated
| @@ -87,8 +87,7 @@ OpenAPI Generator Version | Release Date | OpenAPI Spec compatibility | Notes | |||
| ---------------------------- | ------------ | -------------------------- | ----- | |||
| 4.0.0 (upcoming major release) [SNAPSHOT](https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/openapi-generator-cli/4.0.0-SNAPSHOT/)| TBD | 1.0, 1.1, 1.2, 2.0, 3.0 | Major release with breaking changes (no fallback) | |||
| 3.2.0 (upcoming minor release) [SNAPSHOT](https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/openapi-generator-cli/3.2.0-SNAPSHOT/)| TBD | 1.0, 1.1, 1.2, 2.0, 3.0 | Minor release with breaking changes (with fallbacks) | |||
| 3.1.2-SNAPSHOT (current master, upcoming patch release) [SNAPSHOT](https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/openapi-generator-cli/3.1.2-SNAPSHOT/)| TBD | 1.0, 1.1, 1.2, 2.0, 3.0 | Bugfix release | |||
There was a problem hiding this comment.
Shall we keep this line for 3.1.2-SNAPSHOT?
wing328
reviewed
Jul 18, 2018
README.md
Outdated
| @@ -145,16 +144,16 @@ See the different versions of the [openapi-generator-cli](https://mvnrepository. | |||
|
|
|||
| If you're looking for the latest stable version, you can grab it directly from Maven.org (Java 8 runtime at a minimum): | |||
|
|
|||
| JAR location: `http://central.maven.org/maven2/org/openapitools/openapi-generator-cli/3.1.1/openapi-generator-cli-3.1.1.jar` | |||
| JAR location: `http://central.maven.org/maven2/org/openapitools/openapi-generator-cli/3.1.0/openapi-generator-cli-3.1.0.jar` | |||
There was a problem hiding this comment.
Looks like this change reverts 3.1.1 back to 3.1.0. Same for the other 2 line changes below.
wing328
reviewed
Jul 18, 2018
| @@ -34,7 +34,7 @@ buildscript { | |||
| mavenCentral() | |||
| } | |||
| dependencies { | |||
| classpath "org.openapitools:openapi-generator-gradle-plugin:3.1.1" | |||
| classpath "org.openapitools:openapi-generator-gradle-plugin:3.1.0" | |||
jmini
force-pushed
the
prepare_312-snapshot
branch
from
2402b56 to
5e7009b
Compare
|
I have forced push my second commit that was containing to much changes (as pointed out by the review). It should be good now. Thank you a lot for catching this! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #588