Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-instate Python dependencies #72

Closed
Tracked by #1076
foundrytom opened this issue Aug 30, 2023 · 0 comments · Fixed by #91
Closed
Tracked by #1076

Re-instate Python dependencies #72

foundrytom opened this issue Aug 30, 2023 · 0 comments · Fixed by #91
Assignees
@elliotcmorris

Comments

@foundrytom
Copy link
Contributor

foundrytom commented Aug 30, 2023 •
edited
Loading

What

Re-instate dependencies on openassetio and openassetio-mediacreation

Why

See OpenAssetIO/#58.

This will allow Python package managers to correctly determine if the target runtime environment is compatible with the requirements of the package

ACs

  • openassetio, openassetio-mediacreation, BAL added to dependencies with >= versions set to the minimum supported of each (should be in requirements.txt)
  • Check CI for redundant installation now it is an explicit dependency, clean up.
@foundrytom foundrytom changed the title Move deps to extras Re-instate Python dependencies Sep 7, 2023
@foundrytom foundrytom mentioned this issue Sep 7, 2023
Closed
@elliotcmorris elliotcmorris self-assigned this Nov 28, 2023
elliotcmorris added a commit to elliotcmorris/OpenAssetIO-Manager-BAL that referenced this issue Nov 28, 2023
@elliotcmorris
[Build] Reinstate Mediacreation Dependency
a597ac4 
OpenAssetIO#72

Now that OpenAssetIO/OpenAssetIO#58
(OpenAssetIO/OpenAssetIO#1088)
is complete, we can depend properly on mediacreation, rather
than leaving is an an optional install, since now it'll do the correct
thing.

Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
@elliotcmorris elliotcmorris mentioned this issue Nov 28, 2023
Closed
elliotcmorris added a commit to elliotcmorris/OpenAssetIO that referenced this issue Nov 28, 2023
@elliotcmorris
[CI] Remove mediacreation workaround
13ae13c 
After OpenAssetIO/OpenAssetIO-Manager-BAL#72
is completed, we can now remove the mediacreation dependencies
workaround we had in place.

Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
This was referenced Nov 28, 2023
Merged
Merged
elliotcmorris added a commit to elliotcmorris/OpenAssetIO that referenced this issue Dec 20, 2023
@elliotcmorris
[CI] Remove mediacreation workaround
4480495 
After OpenAssetIO/OpenAssetIO-Manager-BAL#72
is completed, we can now remove the mediacreation dependencies
workaround we had in place.

Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elliotcmorris elliotcmorris

Labels
None yet
Projects
OpenAssetIO Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Build] Reinstate Mediacreation Dependency elliotcmorris/OpenAssetIO-Manager-BAL
2 participants
@foundrytom @elliotcmorris