Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request updates
sphinx-changelog
to work withtowncrier>=24.7.0
.As
sphinx-changelog
uses privatetowncrier
functions it's liable to break for minor releases.In this case the signature of
towncrier._builder.find_fragments
changed under-the-hood, which was the source of the issue.Note that,
towncrier
is also now a little bit richer and can traverse up directory trees to find the configuration file and also has betterbase_directory
management, and so some of the defensive code withinsphinx-changelog
melts away.I've tested this pull-request change against building my own project, and renders its changelog as expected 👍
I also built the
sphinx-changelog
docs and checked thetest_changelogs
page, which appears to render fine.I guess you want to ensure these changes are compatible with your own projects.