Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: In multi-threaded situations, due to incorrect initialization sequence, pika role and cmdstat_map may sometimes be incorrect #2235

Closed
chengyu-l opened this issue Dec 23, 2023 · 0 comments
Labels
3.5.3 ☢️ Bug Something isn't working core

Comments

@chengyu-l
Copy link
Contributor

Is this a regression?

Yes

Description

image

The initialization of pika role and cmdstat_map are placed after the PikaDispatchThread and PikaClientProcessor threads have started, which in extreme cases may cause Redis command execution errors requested by the client. Because the execution order of the main thread, PikaDispatchThread thread, and PikaClientProcessor thread is uncertain. It is possible that PikaDispatchThread and PikaClientProcessor have already received a client request and start to execute commands, the initialization of pika role and cmdstat in the main thread has not been executed yet.

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

Version: v3.5.2

Anything else?

No response

@chengyu-l chengyu-l added the ☢️ Bug Something isn't working label Dec 23, 2023
chejinge pushed a commit that referenced this issue Jan 8, 2024
@luky116 luky116 closed this as completed Jan 8, 2024
KKorpse pushed a commit to KKorpse/pika that referenced this issue Jan 11, 2024
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this issue Jun 8, 2024
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.3 ☢️ Bug Something isn't working core
Projects
None yet
Development

No branches or pull requests

3 participants