fix: command CONFIG SET * reply array length error(#2320) #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
requested review from
lqxhub and
Mixficsol
and removed request for
lqxhub
|
这个这样修改是OK的
|
lqxhub
approved these changes
Jan 20, 2024
AlexStocks
approved these changes
Jan 20, 2024
AlexStocks
merged commit ce938d5
into
OpenAtomFoundation:unstable
12 of 13 checks passed
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…#2320) (OpenAtomFoundation#2336) * fix * change ConfigCmd::ConfigSet return way * func ConfigCmd::ConfigSet use res_ to get return value
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…#2320) (OpenAtomFoundation#2336) * fix * change ConfigCmd::ConfigSet return way * func ConfigCmd::ConfigSet use res_ to get return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2320
1.修复结果：
2.统一了该命令的回复方式，统一使用成员变量
res_回复，由于不需要返回值对应修改了ConfigSet方法的签名3.修复了
AppendStringVector的回复值4.疑问：
pika/src/pika_admin.cc
Line 2064 in 77e87bb
中表示要与
rewrite同步，但是检查后发现configset和configrewrite方法并没有完全同步，这正常吗？5.疑问：延续2，是否要继续修改ConfigCmd::Do方法中用到的其他方法的签名，统一成
ConfigSet的返回形式(用res_成员变量返回)？6.如何格式化？我运行格式化脚本会修改很多文件