feat: support building pika_exporter docker image #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baerwang
reviewed
Mar 5, 2024
docker/Dockerfile_pika_exporter
Outdated
| @@ -0,0 +1,35 @@ | |||
| FROM golang:1.19 AS builder | |||
|
|
|||
| LABEL maintainer="chengyu_l@126.com" | |||
There was a problem hiding this comment.
Why is private email not allowed? @baerwang
There was a problem hiding this comment.
建议添加一个你们团队的邮箱组，这样有问题大家都可以收到，有利于项目维护。
原来的 Dockerfile 也有类似的问题，可以一并改掉。
baerwang
reviewed
Mar 5, 2024
docker/Dockerfile_pika_exporter
Outdated
|
|
||
| FROM ubuntu:22.04 | ||
|
|
||
| LABEL LABEL maintainer="chengyu_l@126.com" |
|
Can you add the build and push processes to the CI?
|
chengyu-l
force-pushed
the
pika_exporter_docker_image
branch
from
5bbdcfe
to
a482575
Compare
added |
|
chengyu-l
force-pushed
the
pika_exporter_docker_image
branch
from
a482575
to
9e38eaf
Compare
machinly
requested changes
Mar 9, 2024
tools/pika_exporter/Makefile
Outdated
| CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build -o bin/$(PROJNAME) | ||
| endif | ||
| endif | ||
| go build -o bin/$(PROJNAME) |
There was a problem hiding this comment.
CGO_ENABLED=0 最好不要去掉
done
docker/Dockerfile_pika_exporter
Outdated
| PIKA_BUILD_DIR=/tmp/pika \ | ||
| PIKA_EXPORTER_BUILD_DIR=/tmp/pika/tools/pika_exporter \ | ||
| # GO111MODULE=on \ | ||
| # GOPROXY=https://goproxy.cn \ |
There was a problem hiding this comment.
最好加个参数，同时支持国内外网络环境
参考 codis/Dockerfile
There was a problem hiding this comment.
最好加个参数，同时支持国内外网络环境 参考 codis/Dockerfile
done
docker/Dockerfile_pika_exporter
Outdated
|
|
||
| FROM ubuntu:22.04 | ||
|
|
||
| LABEL LABEL maintainer="chengyu_l@126.com" |
chengyu-l
force-pushed
the
pika_exporter_docker_image
branch
from
3855d05
to
225fadd
Compare
chengyu-l
force-pushed
the
pika_exporter_docker_image
branch
from
225fadd
to
e9c1b0e
Compare
machinly
approved these changes
Mar 11, 2024
docker/Dockerfile_pika_exporter
Outdated
|
|
||
| FROM ubuntu:22.04 | ||
|
|
||
| LABEL LABEL maintainer="pikiwidb@gmail.com" |
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
…#2451) Co-authored-by: liuchengyu <liuchengyu@360.cn>
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
…#2451) Co-authored-by: liuchengyu <liuchengyu@360.cn>
luky116
pushed a commit
that referenced
this pull request
Mar 18, 2024
Co-authored-by: liuchengyu <liuchengyu@360.cn>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…#2451) Co-authored-by: liuchengyu <liuchengyu@360.cn>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…#2451) Co-authored-by: liuchengyu <liuchengyu@360.cn>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…#2451) Co-authored-by: liuchengyu <liuchengyu@360.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support building pika_exporter docker image