fix: fix ExpectedStale error when expired type is string #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
May 29, 2024
| @@ -406,19 +406,16 @@ class Redis { | |||
| auto meta_type = static_cast<enum DataType>(static_cast<uint8_t>(meta_value[0])); | |||
| if (meta_type == DataType::kZSets || meta_type == DataType::kSets || meta_type == DataType::kHashes) { | |||
There was a problem hiding this comment.
这里整体逻辑改为 switch-case 形式吧
AlexStocks
added a commit
that referenced
this pull request
May 29, 2024
…)" This reverts commit 2962bf4.
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpectedStale didn't consider string type, so if the mismatched key type is string and it's expired, ExpectedStale returns wrong