-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 4.0.0 change log patch to add PR 2785 #2788
Conversation
WalkthroughThis update resolves critical issues impacting data consistency and configurability. The primary fix ensures that iterator resources are properly released in RocksDB to avoid indefinite data referencing issues. Parsing of configuration parameters with units is corrected, abnormal return values in ZREVRANK are addressed, and essential support for automated binary packaging for CentOS platforms is released. Additionally, a bug affecting the GETRANGE command on Codis is fixed. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
CHANGELOG.MD (2)
47-47
: Consider using a more formal verb.The phrase "Solve the issue" can be improved for formality. Consider using "Resolved the issue" instead.
- Solve the issue where failing to destruct 'iter' causes 'pkpatternmatchdel' not to delete 'iter' before returning, potentially leading to RocksDB perpetually referencing a version, causing data inconsistency. + Resolved the issue where failing to destruct 'iter' causes 'pkpatternmatchdel' not to delete 'iter' before returning, potentially leading to RocksDB perpetually referencing a version, causing data inconsistency.
48-48
: Consider using a more formal verb.The phrase "Fixed an issue with abnormal return values" can be improved for formality. Consider using "Resolved an issue with abnormal return values" instead.
- Fixed an issue with abnormal return values in ZREVRANK. + Resolved an issue with abnormal return values in ZREVRANK.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.MD (1 hunks)
- CHANGELOG_CN.MD (2 hunks)
Additional context used
LanguageTool
CHANGELOG.MD
[style] ~49-~49: Consider using a different verb for a more formal wording.
Context: ...shao1](https://github.com/wangshao1) - Fixed an issue with parsing the config parame...(FIX_RESOLVE)
[style] ~51-~51: Consider using a different verb for a more formal wording.
Context: ...shao1](https://github.com/wangshao1) - Fixed an issue with abnormal return values in...(FIX_RESOLVE)
Additional comments not posted (3)
CHANGELOG_CN.MD (3)
47-47
: Ensure the accuracy of the bug fix description.The description for the bug fix at line 47 should be verified for accuracy:
- 修复 iter 未被析构,导致 pkpatternmatchdel 在返回之前不会删除 iter,这可能会导致 rocksdb 永远引用一个版本,导致数据不符合预期的问题.
Ensure that this bug fix accurately describes the issue and the resolution.
48-48
: Ensure the accuracy of the bug fix description.The description for the bug fix at line 48 should be verified for accuracy:
- 修复 config 参数 min-blob-size 带单位时解析错误的问题.
Ensure that this bug fix accurately describes the issue and the resolution.
93-93
: Ensure the accuracy of the bug fix description.The description for the bug fix at line 93 should be verified for accuracy:
- 修复 Codis 侧的 getrange 命令没有返回预期结果的问题.
Ensure that this bug fix accurately describes the issue and the resolution.
Co-authored-by: chejinge <chejinge@360.cn>
Co-authored-by: chejinge <chejinge@360.cn>
Co-authored-by: chejinge <chejinge@360.cn>
Co-authored-by: chejinge <chejinge@360.cn>
Summary by CodeRabbit
Bug Fixes
min-blob-size
config parameter when units are included.ZREVRANK
.getrange
command to return expected results on the Codis side.New Features