feat: Merge branch import_braft #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: import braft --------- Co-authored-by: century <919745273@qq.com> Co-authored-by: alexstocks <alexstocks@foxmail.com> Co-authored-by: dingxiaoshuai123 <2486016589@qq.com>
…oundation#136) * feat: Implementing Redis-Raft commands to build a cluster Co-authored-by: panlei-coder <panleiCSDN@163.com> Co-authored-by: century <919745273@qq.com> Co-authored-by: panlei-coder <62509266+panlei-coder@users.noreply.github.com> Co-authored-by: alexstocks <alexstocks@foxmail.com> Co-authored-by: dingxiaoshuai123 <2486016589@qq.com> Co-authored-by: longfar <ningchangyuan@nuaa.edu.cn>
OpenAtomFoundation#193) * fix: return error status in GetListPeers and add check for return-type in cmake * ci: run actions when pull request to import-braft * Revert "ci: run actions when pull request to import-braft" This reverts commit 727c84d.
* fix: disappearing roles bug * fix: can not find libgflags.a for build in debug version * fix: add download prefix of braft * fix: rm -f xxx
…ld failure on mac (OpenAtomFoundation#206) This reverts commit 7adc3d8.
fix:update brpc & cmake
* style: use spdlog and format codes
rebase to ubstable branch
PSTORE checkpoint interface
'hset & hdel' wrote by braft
…enAtomFoundation#242) * fix: fix some code style and formatting issues with checkpoint pr * fix: resolve code conflicts * fix: fix format * fix: remove unnecessary forward references
* feat: move log_index codes * feat: init log index and update when write successfully * refactor: use deque instead of list to save logidx-seqno
* ci: add a actions for import-braft branch temporarily
* fix: Modify the string matching bug --------- Co-authored-by: longfar <ningchangyuan@nuaa.edu.cn>
snapshot save & load
* fix: find openssl * refactor: remove unused codes
…snapshot when follower installs snapshot (OpenAtomFoundation#279) * feat: overload the PosixFileSystemAdaptor interface to generate real snapshot when follower installs snapshot --------- Co-authored-by: dingxiaoshuai123 <2486016589@qq.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: 丁小帅 <56024577+dingxiaoshuai123@users.noreply.github.com>
* Revert to using the version with independent atomic variables.
* Revert to using the version with independent atomic variables.
…widb into merge_import_braft
github-actions
bot
added
✏️ Feature
longfar-ncy
reviewed
Apr 30, 2024
AlexStocks
reviewed
May 1, 2024
AlexStocks
reviewed
May 1, 2024
AlexStocks
reviewed
May 1, 2024
longfar-ncy
reviewed
May 1, 2024
hahahashen
reviewed
May 1, 2024
hahahashen
reviewed
May 2, 2024
hahahashen
reviewed
May 2, 2024
src/db.cc
Outdated
Comment on lines
71
to
75
| for (int i = 0; i < rocksdb_inst_num_; ++i) { | ||
| // In a new thread, create a checkpoint for the specified rocksdb i | ||
| // In DB::DoBgSave, a read lock is always held to protect the Storage | ||
| // corresponding to this rocksdb i. | ||
| auto res = std::async(std::launch::async, &DB::DoCheckpoint, this, path, i); |
There was a problem hiding this comment.
我觉得这里开启rocksdb_inst_num_个异步任务可以放到Storage层去做，现有逻辑是DB层开启多个异步任务，每个异步任务通过storage层执行某一个rocksdb的检查点创建，感觉DB与rocksdb耦合了（DB:1--storage:1--rocksdb:1），我觉得放到storage层更好，符合原有抽象（DB:1--storage:1--rocksdb:n）（当然也可能理解有误= =）
There was a problem hiding this comment.
嗯嗯 同意你的想法 确实现在的代码是DB感知到了rocksdb的存在，有点不太符合DB:1--storage:1--rocksdb:1这样的抽象。
There was a problem hiding this comment.
我改了， 看一下 @AlexStocks @panlei-coder @hahahashen @longfar-ncy
hahahashen
reviewed
May 2, 2024
dingxiaoshuai123
force-pushed
the
merge_import_braft
branch
from
8eab8f9 to
a4020b0
Compare
dingxiaoshuai123
force-pushed
the
merge_import_braft
branch
from
a4020b0 to
a4a6623
Compare
AlexStocks
previously approved these changes
May 6, 2024
longfar-ncy
reviewed
May 6, 2024
longfar-ncy
reviewed
May 6, 2024
longfar-ncy
reviewed
May 6, 2024
longfar-ncy
reviewed
May 6, 2024
longfar-ncy
reviewed
May 6, 2024
dingxiaoshuai123
force-pushed
the
merge_import_braft
branch
from
66682c3 to
c7e1d39
Compare
panlei-coder
approved these changes
May 6, 2024
longfar-ncy
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
将 import-braft 分支 merge 到了主分支