proper checking of max_obbjects_exceeded

OpenBB-finance · May 10, 2024 · 03915f8 · 03915f8
1 parent b960c16
commit 03915f8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/cli/openbb_cli/controllers/base_platform_controller.py b/cli/openbb_cli/controllers/base_platform_controller.py
@@ -158,11 +158,7 @@ def method(self, other_args: List[str], translator=translator):
                     title = f"{self.PATH}{translator.func.__name__}"
 
                     if obbject:
-                        max_obbjects_exceeded = (
-                            len(session.obbject_registry.obbjects)
-                            >= session.settings.N_TO_KEEP_OBBJECT_REGISTRY
-                        )
-                        if max_obbjects_exceeded:
+                        if session.max_obbjects_exceeded():
                             session.obbject_registry.remove()
 
                         # use the obbject to store the command so we can display it later on results
@@ -214,7 +210,7 @@ def method(self, other_args: List[str], translator=translator):
                             figure=fig,
                         )
 
-                    if max_obbjects_exceeded:
+                    if session.max_obbjects_exceeded():
                         session.console.print(
                             "[yellow]\nMaximum number of OBBjects reached. The oldest entry was removed.[yellow]"
                         )

diff --git a/cli/openbb_cli/session.py b/cli/openbb_cli/session.py
@@ -84,3 +84,9 @@ def is_local(self) -> bool:
 
     def reset(self) -> None:
         pass
+
+    def max_obbjects_exceeded(self) -> bool:
+        """Check if max obbjects exceeded."""
+        return (
+            len(self.obbject_registry.all) >= self.settings.N_TO_KEEP_OBBJECT_REGISTRY
+        )