-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated portfolio/load --rfr options #3074
Conversation
If we show RFR as 0.00%, it is strange to me that the options are either 0.1% or 0.2% and not 0.10, 0.11 etc. I would suggest changing the menu description to 0.0% |
Im confused why we have autocomplete here instead of just using a float type? |
I believe the idea was so that you don't have to type 0.00001 to get 0.1% |
how does an autocomplete of decimals change that you can just enter 0.1? |
Instructions unclear. How we doing this? |
I would get rid of autocomplete of numbers that can take any value (just make sure that we say in the docs 0.1 = 0.1%) |
Make sense, add this to the |
I'm going to remove that for this and other command as well here #3204. |
Ok, should I close this PR? |
Yes good for me |
Description
Fixes #3068
The --rfr option does not round the float values, leading to poor formatting of options.
How has this been tested?
then type
load --rfr` and look at how well-formatted the suggestions are.Checklist:
Others