Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated portfolio/load --rfr options #3074

Closed
wants to merge 5 commits into from
Closed

Updated portfolio/load --rfr options #3074

wants to merge 5 commits into from

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Oct 26, 2022

Description

Fixes #3068
The --rfr option does not round the float values, leading to poor formatting of options.

How has this been tested?

  • Make sure affected commands still run in terminal
    • type python terminal.py portfoliothen typeload --rfr` and look at how well-formatted the suggestions are.
  • Ensure the SDK still works (no need, this only affects a controller)
  • Check any related reports (no need, this only affects a controller)

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Oct 26, 2022
@colin99d colin99d requested a review from jmaslek October 26, 2022 10:17
@JerBouma
Copy link
Contributor

If we show RFR as 0.00%, it is strange to me that the options are either 0.1% or 0.2% and not 0.10, 0.11 etc. I would suggest changing the menu description to 0.0%

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 26, 2022

Im confused why we have autocomplete here instead of just using a float type?

@JerBouma
Copy link
Contributor

I believe the idea was so that you don't have to type 0.00001 to get 0.1%

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 26, 2022

I believe the idea was so that you don't have to type 0.00001 to get 0.1%

how does an autocomplete of decimals change that you can just enter 0.1?

@colin99d
Copy link
Contributor Author

Instructions unclear. How we doing this?

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 27, 2022

I would get rid of autocomplete of numbers that can take any value (just make sure that we say in the docs 0.1 = 0.1%)

@JerBouma
Copy link
Contributor

Make sense, add this to the openbb.co/docs and to the -h.

@montezdesousa
Copy link
Contributor

I'm going to remove that for this and other command as well here #3204.

@colin99d
Copy link
Contributor Author

Ok, should I close this PR?

@JerBouma JerBouma mentioned this pull request Oct 31, 2022
21 tasks
@montezdesousa
Copy link
Contributor

Ok, should I close this PR?

Yes good for me

@colin99d colin99d closed this Oct 31, 2022
@colin99d colin99d deleted the bad_float branch October 31, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] portfolio/load --rfr - too many 0s
4 participants