Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry : remove optional dependencies + set papermill 2.4.0 #3251

Merged
merged 9 commits into from
Nov 7, 2022

Conversation

Chavithra
Copy link
Contributor

@Chavithra Chavithra commented Nov 1, 2022

Description

Here we update the content of these files:

  • pyproject.toml
  • poetry.lock

Change version:

papermill = "^2.4.0"

Removing the following optional element from pyproject.toml

[tool.poetry.dependencies]
kaleido = {version = "^0.2.1", optional = true}

@Chavithra Chavithra added the feat S Small T-Shirt size Feature label Nov 1, 2022
@colin99d
Copy link
Contributor

colin99d commented Nov 1, 2022

@martinb-bb don't we still need torch?

@martinb-ai
Copy link
Contributor

martinb-ai commented Nov 1, 2022

@colin99d Yes we need torch.

@Chavithra
Copy link
Contributor Author

Chavithra commented Nov 1, 2022

@martinb-bb @colin99d it's from optional not from the extras.

We still have torch here:

[tool.poetry.extras]
prediction = ["torch"]

@colin99d
Copy link
Contributor

colin99d commented Nov 1, 2022

@martinb-bb @colin99d it's from optional not from the extras.

We still have torch here:

[tool.poetry.extras]
prediction = ["torch"]

Yes, but if torch is just there then it doesnt know what version to grab.

@martinb-ai
Copy link
Contributor

If you want to make changes to poetry, please check if making a new environment works and installer builds before removing. We cannot afford more issues for building forecasting. ☺️

@simmonsj330
Copy link
Contributor

Also, pyinstaller needs to remain as is in pyproject.toml and as 4.10 or else the build system will not work.

@piiq
Copy link
Contributor

piiq commented Nov 4, 2022

@Chavithra, closing this one without merge to create a new one that solely changes papermill and removes kaleido?

@martinb-ai
Copy link
Contributor

martinb-ai commented Nov 7, 2022

Let me check forecast menu functionality with a new env before we merge this please.

@Chavithra Chavithra merged commit 9b9f379 into OpenBB-finance:main Nov 7, 2022
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to re-generate the requirements.txt files

@Chavithra Chavithra deleted the update_pyproject branch November 7, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants