Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate portfolio class into SDK #3401

Merged
merged 35 commits into from
Nov 14, 2022
Merged

Incorporate portfolio class into SDK #3401

merged 35 commits into from
Nov 14, 2022

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Nov 12, 2022 •
edited
Loading

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Add some examples to make usage clear

How has this been tested?

  • openbb_terminal/miscellaneous/scripts/portfolio/test_portfolio.openbb
  • portfolio report

Added SDK endpoints:

  • openbb.portfolio.load
  • openbb.portfolio.show
  • openbb.portfolio.bench

Sub-endpoints of:

  • openbb.portfolio.alloc

Sub-endpoints of:

  • openbb.portfolio.metric

@montezdesousa montezdesousa added portfolio Portfolio menu platform OpenBB Platform labels Nov 12, 2022
@montezdesousa montezdesousa marked this pull request as ready for review November 13, 2022 19:35
@montezdesousa montezdesousa added the do not merge Label to prevent pull request merge label Nov 14, 2022
@montezdesousa montezdesousa added do not merge Label to prevent pull request merge and removed do not merge Label to prevent pull request merge labels Nov 14, 2022
@montezdesousa montezdesousa removed the do not merge Label to prevent pull request merge label Nov 14, 2022
Chavithra
Chavithra approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@jmaslek jmaslek merged commit 8e9e6bd into main Nov 14, 2022
@jmaslek jmaslek deleted the portfolio_sdk branch November 14, 2022 16:27
@montezdesousa montezdesousa mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@JerBouma JerBouma Awaiting requested review from JerBouma

Assignees
No one assigned
Labels
platform OpenBB Platform portfolio Portfolio menu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] SDK - openbb.portfolio.alloc is missing in the SDK
3 participants
@montezdesousa @Chavithra @jmaslek