Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added single block data from Blockchain.com #3406

Merged
merged 20 commits into from
Jan 4, 2023

Conversation

noubre
Copy link
Contributor

@noubre noubre commented Nov 13, 2022

Added the API for pulling single block JSON data from Blockchain.com. The motivation for this is expand the available API's for BTC blockchain data on the terminal, several more are in the process of being tested. No new dependencies are needed for this addition.

Screenshot 2022-10-26 000048

How has this been tested?

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Copy link
Contributor

@jose-donato jose-donato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to test it locally but looking nice!! request a few minor changes

Thank you for this 🤝 🚀

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Nov 15, 2022
@noubre
Copy link
Contributor Author

noubre commented Nov 18, 2022

Thanks! I'll get on those changes this weekend.

@DidierRLopes
Copy link
Collaborator

Hey @noubre,

Sorry for the delay to review on our side. As per our discussion, we are currently doing a feature freeze for a very big release that will occur next week! Once that is out of the way, we will test this PR and give feedback.

Thanks for contributing! 🙏🏽

@noubre
Copy link
Contributor Author

noubre commented Nov 25, 2022

@DidierRLopes No problem, thanks!

@jose-donato
Copy link
Contributor

Hey, going through this again!

Thanks again, this is amazing and will be interesting for the future refactor im planning for the crypto menu.

Requests:

  1. add autocompletion for the arguments
  2. work if user passes the hash directly without --blockhash e.g., btcblockdata 0000000000000000000385b3a5aa6ba0c4e9d2bf80a54bda9251b96d5f50b2a3
  3. improve error message

image

  1. add command description to file openbb_terminal/miscellaneous/i18n/en.yml
  2. add command source to file openbb_terminal/miscellaneous/data_sources_default.json
  3. add column name to 1st column header of the table - name should be Metric and second column name should be Value and not Values

TODO in the future:

  • Add a feature to get latest blocks (why? i had to go to the web to check a block hash for example)

Let me know if you need any help with any of this.

@noubre
Copy link
Contributor Author

noubre commented Dec 1, 2022

@jose-donato I'll right on those changes. Thanks! By the way, the new terminal 2.0 looks great!

@jose-donato
Copy link
Contributor

@noubre thanks for the quickness 😄
let me know here or on discord in what you need help

@reviewpad reviewpad bot added feat S Small T-Shirt size Feature feat XS Extra small feature feat L Large T-Shirt size Feature and removed feat S Small T-Shirt size Feature feat XS Extra small feature labels Dec 7, 2022
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat L Large T-Shirt size Feature labels Dec 13, 2022
noubre and others added 3 commits December 17, 2022 13:14
…lockData

# Conflicts:
#	openbb_terminal/cryptocurrency/onchain/blockchain_view.py
#	openbb_terminal/cryptocurrency/onchain/onchain_controller.py
#	openbb_terminal/sdk.py
#	reviewpad.yaml
#	tests/openbb_terminal/cryptocurrency/onchain/test_blockchain_view.py
#	website/data/menu/main.yml
#	website/generate_sdk_markdown.py
#	website/generate_terminal_markdown.py
#	website/old_content/terminal/stocks/th/_index.md
#	website/package.json
#	website/src/components/General/ShowcaseItem.tsx
#	website/src/theme/CodeBlock/Content/String.js
#	website/src/theme/Tabs/index.js
@jose-donato
Copy link
Contributor

openbb_terminal\miscellaneous\library\trail_map.csv we just need to add the func to this trailmap to make it available from the sdk. apart from that (and the linting/tests) everything look good :)

@noubre
Copy link
Contributor Author

noubre commented Dec 26, 2022

openbb_terminal\miscellaneous\library\trail_map.csv we just need to add the func to this trailmap to make it available from the sdk. apart from that (and the linting/tests) everything look good :)

Done!

@noubre noubre closed this Dec 26, 2022
@noubre noubre reopened this Dec 26, 2022
Copy link
Contributor

@jose-donato jose-donato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! 👍 just need to wait for the tests to run

@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat S Small T-Shirt size Feature labels Jan 2, 2023
@jmaslek jmaslek merged commit 052c16f into OpenBB-finance:main Jan 4, 2023
@jose-donato
Copy link
Contributor

This was a rough one due to the launch of terminal 2.0
Thanks for sticking around and for your help @noubre 🙌

@noubre
Copy link
Contributor Author

noubre commented Jan 4, 2023

This was a rough one due to the launch of terminal 2.0

Thanks for sticking around and for your help @noubre 🙌

Thanks! Can't wait to do it again. Thanks for your help!

@noubre noubre deleted the feature/BlockchainBlockData branch January 8, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants