Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Fix Docstring formatting/Fix missing, incomplete type hints #3412

Merged
merged 111 commits into from
Nov 15, 2022
Merged

[IMPROVE] Fix Docstring formatting/Fix missing, incomplete type hints #3412

merged 111 commits into from
Nov 15, 2022

Conversation

tehcoderer
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

tehcoderer and others added 30 commits November 3, 2022 19:52
@tehcoderer
Fixes
e8a463b
@tehcoderer
Update stocks_helper.py
4ee7d86
@tehcoderer
update git-actions set-output to new format
429ad26
@tehcoderer
Update stocks_helper.py
d6a33fe
@colin99d
Merge branch 'main' into bug-fixes
31d94da
@tehcoderer
Merge branch 'main' into bug-fixes
3860427
@tehcoderer
Update terminal_helper.py
0e9fafe
@tehcoderer
Merge branch 'main' into bug-fixes
0da215a
@tehcoderer
Merge branch 'main' into bug-fixes
c9da290
@tehcoderer
Merge branch 'main' into bug-fixes
fa2d868
@jmaslek
Merge branch 'main' into bug-fixes
741e9a2
@tehcoderer
removed LineAnnotateDrawer from qa_view
40e1a5f
@tehcoderer
lint
bf47af6
@tehcoderer
Merge branch 'OpenBB-finance:main' into sdk-refactor
b05736a
@tehcoderer
few changes
1d8a690
@tehcoderer
Merge branch 'sdk-refactor' of https://github.com/tehcoderer/OpenBBTe…
a18927b 
…rminal into sdk-refactor
@tehcoderer
updates
325552a
@tehcoderer
sdk auto gen modules done
5791bac
@tehcoderer
update branch
07f6a56
@tehcoderer
Update stocks_helper.py
8767237
@tehcoderer
updates to changed imports, and remove first sdk_modules
36e41a6
@tehcoderer
Update generate_sdk.py
587a401
@tehcoderer
Update generate_sdk.py
8c96bea
@tehcoderer
pylint
6913766
@tehcoderer
revert stocks_helper
146aee1
@tehcoderer
Update generate_sdk.py
3f48c09
@tehcoderer
Update sdk.py
67fc691
@tehcoderer
Update generate_sdk.py
fb936dc
@tehcoderer
full auto generation, added sdk.py/controllers creation
4beded4
@tehcoderer
missed enable forecasting
bf5e22a
tehcoderer and others added 26 commits November 15, 2022 09:11
@tehcoderer
Update generate_sdk.py
f3ff0cd
@andrewkenreich
last of my section
7b65b2c
@tehcoderer
porfolio
39391a8
@tehcoderer
Merge branch 'OpenBBTerminal-main' of https://github.com/tehcoderer/O…
78629c9 
…penBBTerminal into fix-docstrings
@tehcoderer
po
66ef027
@tehcoderer
Update optimizer_model.py
8ad6ea8
@andrewkenreich
fixing more things
53611f8
@andrewkenreich
changes
55710c8
@andrewkenreich
few more
1081f99
@andrewkenreich
keys done
2d3c55e
@tehcoderer
update
2b739e4
@andrewkenreich
Merge branch 'fix-docstrings' of https://github.com/tehcoderer/OpenBB…
e365a1d 
…Terminal into fix-docstrings
@tehcoderer
fixes
121c37d
@tehcoderer
Update generate_sdk_markdown.py
824c242
@tehcoderer
Update generate_sdk_markdown.py
d3fa43b
@andrewkenreich
Merge branch 'fix-docstrings' of https://github.com/tehcoderer/OpenBB…
82b8ad5 
…Terminal into fix-docstrings
@tehcoderer
mypy forecast fix
9997aa5
@tehcoderer
Update generate_sdk_markdown.py
d6eeffb
@tehcoderer
Update generate_sdk_markdown.py
d708142
@tehcoderer
Update generate_sdk_markdown.py
7f8d2cf
@andrewkenreich
Merge branch 'fix-docstrings' of https://github.com/tehcoderer/OpenBB…
4b450be 
…Terminal into fix-docstrings
@andrewkenreich
fixes
41a24d1
@tehcoderer
forecast fixes
b3ff42d
@andrewkenreich
Merge branch 'fix-docstrings' of https://github.com/tehcoderer/OpenBB…
c573369 
…Terminal into fix-docstrings
@andrewkenreich
one more fix
b052153
@tehcoderer
Update coinbase_model.py
108fbfd
jmaslek
jmaslek approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. super stars

@jmaslek jmaslek merged commit 59d8b36 into OpenBB-finance:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaslek jmaslek jmaslek approved these changes

Assignees
No one assigned
Labels
docs Code documentation enhancement Enhancement feat XL Extra Large feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tehcoderer @jmaslek @colin99d @jose-donato @andrewkenreich