Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress logs for dashboards #3522

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

hjoaquim
Copy link
Contributor

This PR aims to add log suppression to the dashboards, similarly to what happens in the reports.

Currently, there is no suppression on the dashboards_controller what leads to having the impression of a sdk "sub_app" running while using e.g. an installer version of the terminal, example:

image

How to replicate/test:

  1. On main:

    • Open the terminal and go to dashboards
    • Run crypto -n
    • Check your logging directory and see that 4 files were generated (wrongly - as it was supposed to be only 2). Open the .log files and see "LOGGING_SUB_APP": "sdk" in the configs.
  2. Fixed branch:

    • Repeat the process - now you should only have 2 files and see "LOGGING_SUB_APP": "terminal"

@hjoaquim hjoaquim added bug Fix bug dashboards dashboards analytics Logging and analytics labels Nov 22, 2022
@hjoaquim hjoaquim self-assigned this Nov 22, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 22, 2022
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@hjoaquim hjoaquim merged commit d565f7d into OpenBB-finance:main Nov 22, 2022
@hjoaquim hjoaquim deleted the dashboards_logs branch November 22, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics Logging and analytics bug Fix bug dashboards dashboards feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants