Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove export choices on export argument #3655

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Nov 29, 2022

See below. After changing the choices, we get something like in #3508. The reason is that the refactoring for choices forces the input to be a file type.

By removing this we have the following:

2022 Nov 29, 11:56 (🦋) /stocks/ $ load aapl --export aapl1.csv

Loading Daily data for AAPL with starting period 2019-11-25.

Company:  Apple Inc.
Exchange: NASDAQ/NMS (GLOBAL MARKET)
Currency: USD

                                          AAPL Performance                                          
┏━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ 1 Day   ┃ 1 Week  ┃ 1 Month ┃ 1 Year ┃ YTD     ┃ Volatility (1Y) ┃ Volume (10D avg) ┃ Last Price ┃
┡━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ -4.53 % │ -4.67 % │ -0.24 % │ -7.5 % │ -20.3 % │ 35.48 %         │ 76.42 M          │ 144.22     │
└─────────┴─────────┴─────────┴────────┴─────────┴─────────────────┴──────────────────┴────────────┘

Saved file: /Users/james/OpenBBUserData/exports/aapl1.csv

2022 Nov 29, 11:56 (🦋) /stocks/ $ load aapl --export csv

Loading Daily data for AAPL with starting period 2019-11-25.

Company:  Apple Inc.
Exchange: NASDAQ/NMS (GLOBAL MARKET)
Currency: USD

                                          AAPL Performance                                          
┏━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ 1 Day   ┃ 1 Week  ┃ 1 Month ┃ 1 Year ┃ YTD     ┃ Volatility (1Y) ┃ Volume (10D avg) ┃ Last Price ┃
┡━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ -4.53 % │ -4.67 % │ -0.24 % │ -7.5 % │ -20.3 % │ 35.48 %         │ 76.42 M          │ 144.22     │
└─────────┴─────────┴─────────┴────────┴─────────┴─────────────────┴──────────────────┴────────────┘

Saved file: /Users/james/OpenBBUserData/exports/20221129_115839_OpenBBTerminal_openbb_terminal_load.csv
2022 Nov 29, 11:58 (🦋) /stocks/ $ load aapl --export cfgfgsfg

Filename 'cfgfgsfg' provided is not valid!
Loading Daily data for AAPL with starting period 2019-11-25.

Since this is the base controller, it will port.

Note: Fixes #3508

@jmaslek jmaslek added the enhancement Enhancement label Nov 29, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 29, 2022
@Chavithra Chavithra self-requested a review November 29, 2022 17:16
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@Chavithra Chavithra merged commit a12b788 into OpenBB-finance:main Nov 29, 2022
@jmaslek jmaslek deleted the custom_export branch February 14, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Export does not allow you to name the file, must be file type only.
2 participants