Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove case sensitive path files #3684

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

nicktids
Copy link
Contributor

@nicktids nicktids commented Dec 2, 2022

Description

  • Summary of the change / bug fix.
    remove case sensitive paths as causing issues

  • Link # issue, if applicable.

on a fresh clone on wsl2 the following error occurred so cleaning up the upper case files

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

'tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_messari_model/test_get_fundraising[ETH].txt'
'tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_messari_model/test_get_fundraising[eth].txt'
'tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_messari_model/test_get_governance[ETH].txt'
'tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_messari_model/test_get_governance[eth].txt'

  • Screenshot of the feature or the bug before/after fix, if applicable.

  • Relevant motivation and context.
    will not see both files so kept the lowercase version

  • List any dependencies that are required for this change.

How has this been tested?

no tests as just removing 2 case sensitive file names

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_messari_model/test_get_fundraising[ETH].txt'
  'tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_messari_model/test_get_fundraising[eth].txt'
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_messari_model/test_get_governance[ETH].txt'
  'tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_messari_model/test_get_governance[eth].txt'
@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 2, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Dec 2, 2022

Thanks!!

@jmaslek jmaslek merged commit 1251bda into OpenBB-finance:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants