Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Reviewpad configuration #3710

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Refactor: Reviewpad configuration #3710

merged 2 commits into from
Dec 6, 2022

Conversation

ferreiratiago
Copy link
Contributor

Description

This pull request introduces a refactor to the current reviewpad configuration file by taking advantage of groups.

It also solves the problem of reviewpad adding more than one size label when the pull request size keeps changing. For instance, a pull request that changes less than 100 lines will be labeled by Reviewpad with feat XS. However, if the total number of changed lines goes up 100 lines, Reviewpad will add the label label S but won't remove the previous feat XS label. The pull request will end up with the two labels feat XS and feat S.

How has this been tested?

The configuration was tested using Reviewpad playground.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad
Copy link

reviewpad bot commented Dec 5, 2022

Reviewpad Report (Reviewpad ran in dry-run mode because configuration has changed)

📜 Executed actions

$removeLabels($group("size-labels"))
$addLabel("feat XS")

@jmaslek jmaslek requested a review from piiq December 6, 2022 18:38
@piiq piiq added the feat XS Extra small feature label Dec 6, 2022
@jmaslek jmaslek merged commit 91fef00 into OpenBB-finance:main Dec 6, 2022
@ferreiratiago ferreiratiago mentioned this pull request Dec 8, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants