Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecasting Pylint Pre-Commit Error Fixes #3729

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

simmonsj330
Copy link
Contributor

Description

When using pre-commit hooks, pylint was snagged by the following errors:

************* Module openbb_terminal.forecast.mstl_model
openbb_terminal/forecast/mstl_model.py 114: E1101 Instance of 'StatsForecast' has no 'cross_validation' member (no-member)
openbb_terminal/forecast/mstl_model.py 123: E1101 Instance of 'StatsForecast' has no 'forecast' member (no-member)
************* Module openbb_terminal.forecast.autoarima_model
openbb_terminal/forecast/autoarima_model.py 101: E1101 Instance of 'StatsForecast' has no 'cross_validation' member (no-member)
openbb_terminal/forecast/autoarima_model.py 110: E1101 Instance of 'StatsForecast' has no 'forecast' member (no-member)
************* Module openbb_terminal.forecast.autoselect_model
openbb_terminal/forecast/autoselect_model.py 147: E1101 Instance of 'StatsForecast' has no 'cross_validation' member (no-member)
openbb_terminal/forecast/autoselect_model.py 161: E1101 Instance of 'StatsForecast' has no 'forecast' member (no-member)
************* Module openbb_terminal.forecast.seasonalnaive_model
openbb_terminal/forecast/seasonalnaive_model.py 104: E1101 Instance of 'StatsForecast' has no 'cross_validation' member (no-member)
openbb_terminal/forecast/seasonalnaive_model.py 113: E1101 Instance of 'StatsForecast' has no 'forecast' member (no-member)
************* Module openbb_terminal.forecast.autoces_model
openbb_terminal/forecast/autoces_model.py 104: E1101 Instance of 'StatsForecast' has no 'cross_validation' member (no-member)
openbb_terminal/forecast/autoces_model.py 113: E1101 Instance of 'StatsForecast' has no 'forecast' member (no-member)
************* Module openbb_terminal.forecast.autoets_model
openbb_terminal/forecast/autoets_model.py 105: E1101 Instance of 'StatsForecast' has no 'cross_validation' member (no-member)
openbb_terminal/forecast/autoets_model.py 114: E1101 Instance of 'StatsForecast' has no 'forecast' member (no-member)
************* Module openbb_terminal.forecast.rwd_model
openbb_terminal/forecast/rwd_model.py 93: E1101 Instance of 'StatsForecast' has no 'cross_validation' member (no-member)
openbb_terminal/forecast/rwd_model.py 102: E1101 Instance of 'StatsForecast' has no 'forecast' member (no-member)

Per @martinb-bb, this is a false, positive. As such, E1101 was added to the pylint ignore line in each file.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@simmonsj330 simmonsj330 added bug Fix bug forecast Forecast menu labels Dec 8, 2022
@simmonsj330 simmonsj330 self-assigned this Dec 8, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 8, 2022
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 8, 2022
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 8, 2022
@jmaslek jmaslek merged commit 6e2f8b9 into OpenBB-finance:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature forecast Forecast menu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants