Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making install instructions more clear #3736

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Conversation

andrewkenreich
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 9, 2022
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 9, 2022
Copy link
Contributor

@JerBouma JerBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention the requirements page here as well so people are aware why it might not work for them. Saw a guy complain Linux wasn't working but he was using 32bit which we mention in the Requirements doesn't work. We need to refer to it a bit more.

@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 9, 2022
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 9, 2022
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 11, 2022
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 12, 2022
@jmaslek jmaslek merged commit 3ddb092 into main Dec 13, 2022
@jmaslek jmaslek deleted the install-instructions-update branch December 13, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants